Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #959

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #959

wants to merge 3 commits into from

Conversation

Kateryna99
Copy link

@Kateryna99 Kateryna99 commented Jul 12, 2024 •
edited
Loading

BudnikOleksii
BudnikOleksii suggested changes Jul 13, 2024
View reviewed changes
Copy link

@BudnikOleksii BudnikOleksii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a link to the demo so a reviewer can test the UI

@Kateryna99
Copy link
Author

Kateryna99 commented Jul 14, 2024 •
edited
Loading

DEMO LINK

I forgot , sorrryyyyy

@Kateryna99 Kateryna99 requested a review from BudnikOleksii July 14, 2024 07:31
BudnikOleksii
BudnikOleksii approved these changes Jul 14, 2024
View reviewed changes
Copy link

@BudnikOleksii BudnikOleksii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀
Approved. Just a few suggestions:

  • Buttons on mobile should have the same width as in the design:
    image
  • Social media icons could be links to social media

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BudnikOleksii BudnikOleksii BudnikOleksii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kateryna99 @BudnikOleksii