Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #960

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

SerhiiDielovskiy
Copy link

@TarasHoliuk
Copy link

  1. Wrong font-family (there is more detailed comment about that):
    image

  2. This button should lead to the closest section (read requirements):
    image

  3. Add hover effect to images:
    image

  4. Add styles to form:
    image

  5. Add hover effect to all links. Social media icons should be links to the corresponding social media (main page):
    image

  6. There should be a menu with navigation links when you click on the "burger" menu button:
    image

  7. fix all lint errors

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, carefully read the checklist. Feel free to ask for help in the chat if you have any questions or need help

}

&__title {
font-family: Poppins;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should define the main font-family once, for the entire page (on HTML or body level tag). Also, add generic font-family, as recommended (lint errors)

If some text has different font-family then redefine it in that place (but that more like exceptions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants