-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution added #961
base: master
Are you sure you want to change the base?
Solution added #961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Let's improve your page
- Add cursor pointer for all clickable elements
- Add hover effects for all clickable elements
-
Add transition for hover effects everywhere
-
The text in placeholder must be white
- These elements must be links and add hover effects here
- You need to implement the burger menu when user clicking on this icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, the comments from the previous review still not fixed, also, you need to make a deploy after your changes.
I had issues with my deploy. Now everything seems to work well) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
To improve:
- Add hover effects here
- Fix the image width here, check it on the layout
- Add transition for all hover effects on the page
- The burger menu should be the entire width and height of the browser window. Also add transition when this menu appears on the page and remove scroll when this menu is open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Good progress, almost done 👍
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Let's reach all points from the checklist 🙂
Also, added a few more small suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
DEMO LINK