Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution added #961

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Solution added #961

wants to merge 8 commits into from

Conversation

ansnihur
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add cursor pointer for all clickable elements
image
  1. Add hover effects for all clickable elements
image
  1. Add transition for hover effects everywhere

  2. The text in placeholder must be white

image
  1. These elements must be links and add hover effects here
image
  1. You need to implement the burger menu when user clicking on this icon
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the comments from the previous review still not fixed, also, you need to make a deploy after your changes.

@ansnihur
Copy link
Author

I had issues with my deploy. Now everything seems to work well)

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-07-16 at 15 20 29
Screenshot 2024-07-16 at 15 20 48
Check hovers in Figma
Screenshot 2024-07-16 at 15 20 22
Check the layout here

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
To improve:

  1. Add hover effects here
image
  1. Fix the image width here, check it on the layout
image
  1. Add transition for all hover effects on the page
image image image
  1. The burger menu should be the entire width and height of the browser window. Also add transition when this menu appears on the page and remove scroll when this menu is open
image

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-07-18 at 15 47 40
There is a horizontal scroll
Screenshot 2024-07-18 at 15 46 29
Check the layout here

@TarasHoliuk
Copy link

Hi! Good progress, almost done 👍
Let's improve a few more things (most of them from the checklist):

  1. Disable the scroll when the menu is open. Hint: there was instruction on how to do it in the previous task checklist
    image

  2. Remove scroll in the last input:
    image

  3. I'd recommend to make these links to corresponding social media main pages:
    image

  4. Checklist, point 15 (and similar 11):
    image

  5. Checklist, points 13, 14:
    image

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Let's reach all points from the checklist 🙂
Also, added a few more small suggestions

@ansnihur ansnihur requested a review from TarasHoliuk July 18, 2024 17:43
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants