Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #987

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Develop #987

wants to merge 5 commits into from

Conversation

jooaasss
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Change the autofill styles for the form fields
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image
  1. Add hover effects for all clickable elements on the page
image
  1. Add the horizontal padding for the content
image

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Check the layout for 1024px. It should match the Figma

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
To improve:

  1. The gap between these blocks must be are same
image
  1. Don't need to refresh page after submitting form and scroll to top, you need only reset form fields
image
  1. Add hover effects here
image
  1. Don't need to write fixed width for these blocks on the mobile version
image

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing idea with change theme!

  1. it should be the textarea tag
image
  1. the button should have type submit
image
  1. and then update your form to prevent reloading
    <form onsubmit="this.reset(); return false;">

@jooaasss jooaasss requested a review from etojeDenys October 25, 2024 07:26
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants