-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution-Form #797
base: master
Are you sure you want to change the base?
Solution-Form #797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start! Improve the code readability according to my comments and check the checklist one more time.
src/index.html
Outdated
<form | ||
action="https://mate-academy-form-lesson.herokuapp.com/create-application" | ||
method="post"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<form | |
action="https://mate-academy-form-lesson.herokuapp.com/create-application" | |
method="post"> | |
<form | |
action="https://mate-academy-form-lesson.herokuapp.com/create-application" | |
method="post" | |
> |
src/index.html
Outdated
</legend> | ||
<label class="field"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add empty lines between multiline sibling blocks of HTML
</legend> | |
<label class="field"> | |
</legend> | |
<label class="field"> |
src/index.html
Outdated
name="answer" | ||
value="Yes" | ||
> | ||
<label for="yes"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the labels here. It doesn't work correctly for now
Screen.Recording.2023-06-01.at.14.00.14.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Anastasiia-Svintsova about this part I do not understand what I have to do? It's giving only one choice yes or no, do I have to change both to be selected? Please explain to me and thanks for your suggestions :)
src/index.html
Outdated
<button class="frame" | ||
type="submit" | ||
name="submit"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<button class="frame" | |
type="submit" | |
name="submit"> | |
<button | |
class="frame" | |
type="submit" | |
name="submit" | |
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Pay attention to my comments and fix the code style, please
src/index.html
Outdated
@@ -11,7 +11,215 @@ | |||
<link rel="stylesheet" href="./style.css"> | |||
</head> | |||
<body> | |||
<h1>HTML Form</h1> | |||
<!-- <h1>HTML Form</h1> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comments
src/index.html
Outdated
> | ||
|
||
<fieldset class="frame"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't. add spaces between parent and child components
> | |
<fieldset class="frame"> | |
> | |
<fieldset class="frame"> |
src/index.html
Outdated
> | ||
|
||
</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix it everywhere
> | |
</label> | |
> | |
</label> |
src/index.html
Outdated
<label class="field"> | ||
Do you love cats? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These radio buttons still don't work correctly. Test it more carefully, please. Ask questions in the chat if you need to
Screen.Recording.2023-06-02.at.13.55.45.mov
src/index.html
Outdated
<select name="cars" | ||
id="cars" multiple> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the code style
<select name="cars" | |
id="cars" multiple> | |
<select | |
name="cars" | |
id="cars" | |
multiple | |
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I like it!
https://nenatre.github.io/layout_html-form/
https://nenatre.github.io/layout_html-form/report/html_report/