Develop #4193
Open
Develop #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timossha
commented
Nov 30, 2023
timossha
commented
- DEMO LINK
- TEST REPORT LINK
volodymyr-soltys97
suggested changes
Dec 1, 2023
src/index.html
Outdated
| <h1>Moyo header</h1> | ||
| <header class="header"> | ||
| <a class="logoLink" href="index.html"> | ||
| <img class="logo" src="https://s3-alpha-sig.figma.com/img/833f/9aab/47d660efd384318772b6b8040db831aa?Expires=1702252800&Signature=SaF7YW0H7Sok3Ym~DTrBU7ICffnIqRz85sOzyK5yhUxkE3UQ7SZVMqgwJzD7mdtcXPnACi7Ud-B6xHi8GNoLdzYQcKpuN4FSzrfnAW-HFEtzHrr8llePYN-4UVeqlsxGrWvAs4EmLpOGsCinSSqxoEUfy-jmuU3cRmGQH31GOeuBGQbY33Kv1udxQyCOd00xIqkEwSSPhItWv-Ihi0IHbMzH61-wKa1DabtMzHARFKwpbi-ULMUdDjVRxEl4E32z92yZqtRoguXwEVaTgr4GNGJ5UKwjJSJ5NNv3Qv0mwjGoFRAq67O7YmIO28GekphRU5W6kzgVJhd4HUe1Ul3zLg__&Key-Pair-Id=APKAQ4GOSFWCVNEHN3O4" |
src/index.html
Outdated
Comment on lines
29
to
30
| </a> | ||
| <nav class="nav"> |
There was a problem hiding this comment.
Suggested change
| </a> | |
| <nav class="nav"> | |
| </a> | |
| <nav class="nav"> |
src/index.html
Outdated
Comment on lines
31
to
34
| <ul class="linkList"> | ||
| <li> | ||
| <a id="firstLink" class="is-active navLink">Apple</a> | ||
| </li> |
There was a problem hiding this comment.
Need to fix it everywhere
Suggested change
| <ul class="linkList"> | |
| <li> | |
| <a id="firstLink" class="is-active navLink">Apple</a> | |
| </li> | |
| <ul class="nav__list"> | |
| <li class="nav__item"> | |
| <a class="is-active nav__link">Apple</a> | |
| </li> |
src/index.html
Outdated
Comment on lines
37
to
38
| </li> | ||
| <li> |
There was a problem hiding this comment.
Add a blank line between the links
Suggested change
| </li> | |
| <li> | |
| </li> | |
| <li> |
src/style.css
Outdated
| height: 60px; | ||
| } | ||
|
|
||
| header { |
src/style.css
Outdated
| padding: 0 50px; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| box-sizing: border-box; |
There was a problem hiding this comment.
Move box-sizing to the * selector
src/style.css
Outdated
| } | ||
|
|
||
| header { | ||
| background-color: #fff; |
There was a problem hiding this comment.
Default value
Suggested change
| background-color: #fff; |
src/style.css
Outdated
| justify-content: space-between; | ||
| align-items: center; | ||
| box-sizing: border-box; | ||
| font-family: Roboto, sans-serif; |
There was a problem hiding this comment.
Move font-family to the html selector
src/style.css
Outdated
| } | ||
|
|
||
|
|
||
| li { |
There was a problem hiding this comment.
Use a classes selector everywhere
SanyaBratashchuk
approved these changes
Dec 2, 2023
Comment on lines
+74
to
+80
| .nav__list > li { | ||
| margin-left: 20px; | ||
| } | ||
|
|
||
| .nav__list > li:first-child { | ||
| margin-left: 0; | ||
| } |
There was a problem hiding this comment.
Suggested change
| .nav__list > li { | |
| margin-left: 20px; | |
| } | |
| .nav__list > li:first-child { | |
| margin-left: 0; | |
| } | |
| .nav__item { | |
| margin-left: 20px; | |
| } | |
| .nav__item:first-child { | |
| margin-left: 0; | |
| } |
| color: var(--link-color); | ||
| } | ||
|
|
||
| li:hover > a{ |
There was a problem hiding this comment.
Suggested change
| li:hover > a{ | |
| nav__link:hover{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.