add task solution #4451
Open
add task solution #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ehulinian
commented
Jan 27, 2024
Ehulinian
commented
- DEMO LINK
- TEST REPORT LINK
volodymyr-soltys97
suggested changes
Jan 27, 2024
src/index.html
Outdated
Comment on lines
14
to
16
| <link rel="preconnect" | ||
| href="https://fonts.gstatic.com/" | ||
| crossorigin="true"> |
There was a problem hiding this comment.
Need to fix code style everywhere
Suggested change
| <link rel="preconnect" | |
| href="https://fonts.gstatic.com/" | |
| crossorigin="true"> | |
| <link | |
| rel="preconnect" | |
| href="https://fonts.gstatic.com/" | |
| crossorigin="true" | |
| > |
src/index.html
Outdated
Comment on lines
24
to
25
| <img src="./images/logo.png" alt="Moyo logo" | ||
| class="logo__image"> |
There was a problem hiding this comment.
The same as above, check and fix it everywhere
Suggested change
| <img src="./images/logo.png" alt="Moyo logo" | |
| class="logo__image"> | |
| <img | |
| src="./images/logo.png" | |
| alt="Moyo logo" | |
| class="logo__image" | |
| > |
src/index.html
Outdated
Comment on lines
35
to
36
| </li> | ||
| <li class="nav__item"> |
There was a problem hiding this comment.
Add the blank line between the links
Suggested change
| </li> | |
| <li class="nav__item"> | |
| </li> | |
| <li class="nav__item"> |
src/style.css
Outdated
| } | ||
|
|
||
| .nav__link:hover { | ||
| color: #00acdc; |
There was a problem hiding this comment.
Create the variable for repeated color and use it everywhere
src/style.css
Outdated
| color: #00acdc; | ||
| } | ||
|
|
||
| .nav__link.is-active { |
There was a problem hiding this comment.
Suggested change
| .nav__link.is-active { | |
| .is-active { |
src/style.css
Outdated
| color: #00acdc; | ||
| } | ||
|
|
||
| .nav__link.is-active::after { |
There was a problem hiding this comment.
Suggested change
| .nav__link.is-active::after { | |
| .is-active::after { |
Esceype
suggested changes
Feb 7, 2024
src/index.html
Outdated
Comment on lines
26
to
29
| <a href="#" class="logo"> | ||
| <img src="./images/logo.png" | ||
| alt="Moyo logo" | ||
| class="logo__image"> |
There was a problem hiding this comment.
Suggested change
| <a href="#" class="logo"> | |
| <img src="./images/logo.png" | |
| alt="Moyo logo" | |
| class="logo__image"> | |
| <a href="#" class="logo"> | |
| <img | |
| src="./images/logo.png" | |
| alt="Moyo logo" | |
| class="logo__image" | |
| > |
src/index.html
Outdated
Comment on lines
47
to
49
| <a href="#" | ||
| class="nav__link" | ||
| data-qa="hover"> |
There was a problem hiding this comment.
Suggested change
| <a href="#" | |
| class="nav__link" | |
| data-qa="hover"> | |
| <a | |
| href="#" | |
| class="nav__link" | |
| data-qa="hover" | |
| > |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.