Develop #4533
Closed
Develop #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MykolaDotsenko
commented
Feb 7, 2024
•
MykolaDotsenko
commented
- DEMO LINK
- TEST REPORT LINK
- Header height is set in 1 place (for the links)
- Content is vertically centered (for any header height)
- CSS is used to show all letters in Uppercase (don't type them in HTML)
- Logo is an image wrapped with a link
- CSS Variable is used for a blue color
- Pseudo-element is used for a blue line below the active link
- Code follows all the Code Style Rules ❗️
OleziO
suggested changes
Feb 7, 2024
src/index.html
Outdated
| </a> | ||
| <nav class="header__nav"> | ||
| <ul class="header__list"> | ||
| <li class="nav__item"><a href="#" class="nav__link is-active">Apple</a></li> |
There was a problem hiding this comment.
Make links more meaningful.
Examples: #apple, #samsung, etc.
src/style.css
Outdated
| white-space: nowrap; | ||
| text-decoration: none; | ||
| text-transform: uppercase; | ||
| color: #000; |
There was a problem hiding this comment.
Move all repeatable colors to the CSS variables.
OleziO
suggested changes
Feb 7, 2024
| </a> | ||
| <nav class="header__nav"> | ||
| <ul class="header__list"> | ||
| <li class="nav__item"><a href="#apple" class="nav__link is-active">Apple</a></li> |
There was a problem hiding this comment.
Suggested change
| <li class="nav__item"><a href="#apple" class="nav__link is-active">Apple</a></li> | |
| <li class="nav__item"> | |
| <a href="#apple" class="nav__link is-active"> | |
| Apple | |
| </a> | |
| </li> |
Co-authored-by: Oleh Herasymchuk <[email protected]>
|
в мене прюцюють стилі. де помилка? |
ЯК???? |
OleziO
suggested changes
Feb 7, 2024
| </a> | ||
| <nav class="header__nav"> | ||
| <ul class="header__list"> | ||
| <li class="nav__item"><a href="#apple" class="nav__link is-active">Apple</a></li> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.