-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #4535
Develop #4535
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,3 +1,4 @@ | ||||||||||||||||||||
|
||||||||||||||||||||
<!doctype html> | ||||||||||||||||||||
<html lang="en"> | ||||||||||||||||||||
<head> | ||||||||||||||||||||
|
@@ -6,9 +7,33 @@ | |||||||||||||||||||
content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"> | ||||||||||||||||||||
<meta http-equiv="X-UA-Compatible" content="ie=edge"> | ||||||||||||||||||||
<title>Moyo header</title> | ||||||||||||||||||||
<link rel="preconnect" href="https://fonts.googleapis.com"> | ||||||||||||||||||||
<link rel="preconnect" href="https://fonts.gstatic.com" | ||||||||||||||||||||
crossorigin = "anonymous"> | ||||||||||||||||||||
<link href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;500;700&display=swap" rel="stylesheet"> | ||||||||||||||||||||
<link rel="stylesheet" href="./style.css"> | ||||||||||||||||||||
</head> | ||||||||||||||||||||
<body> | ||||||||||||||||||||
<h1>Moyo header</h1> | ||||||||||||||||||||
<header class="header"> | ||||||||||||||||||||
<a class="header__logo" href="#" | ||||||||||||||||||||
aria-label="Home"> | ||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||
<img src="./images/logo.png" alt="logo"> | ||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||
</a> | ||||||||||||||||||||
<nav class="header__nav"> | ||||||||||||||||||||
<ul class="header__list"> | ||||||||||||||||||||
<li class="nav__item"><a href="#" class="nav__link is-active">Apple</a></li> | ||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to fix code style everywhere and add the blank line between the links
Suggested change
|
||||||||||||||||||||
<li class="nav__item"><a href="#" class="nav__link">Samsung</a></li> | ||||||||||||||||||||
<li class="nav__item"><a href="#" class="nav__link">Smartphones</a></li> | ||||||||||||||||||||
<li class="nav__item"> | ||||||||||||||||||||
<a href="#" class="nav__link" | ||||||||||||||||||||
data-qa="hover">Laptops & computers</a> | ||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||
</li> | ||||||||||||||||||||
<li class="nav__item"><a href="#" class="nav__link">Gadgets</a></li> | ||||||||||||||||||||
<li class="nav__item"><a href="#" class="nav__link">Tablets</a></li> | ||||||||||||||||||||
<li class="nav__item"><a href="#" class="nav__link">Photo</a></li> | ||||||||||||||||||||
<li class="nav__item"><a href="#" class="nav__link">Video</a></li> | ||||||||||||||||||||
</ul> | ||||||||||||||||||||
</nav> | ||||||||||||||||||||
</header> | ||||||||||||||||||||
</body> | ||||||||||||||||||||
</html> |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,3 +1,78 @@ | ||||||
:root { | ||||||
--main-color: #00acdc; | ||||||
} | ||||||
|
||||||
body { | ||||||
font-family: Roboto, sans-serif; | ||||||
margin: 0; | ||||||
} | ||||||
|
||||||
.header { | ||||||
display: flex; | ||||||
justify-content: space-between; | ||||||
align-items: center; | ||||||
background-color: #fff; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Default color
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. напишіть що конкретно треба або пояснення There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. мається на увазі що це і так дефолтний колір, то це правило тут не потрібне, просто видали його |
||||||
color: #000; | ||||||
position: relative; | ||||||
padding: 0 50px; | ||||||
} | ||||||
|
||||||
.header img { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use the classes selector for image There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. як??????????? поясніть. Я учусь There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. додай атрибут клас для цієї картинки і використовуй його замість img |
||||||
height: 100%; | ||||||
width: 100%; | ||||||
} | ||||||
|
||||||
.header__logo { | ||||||
display: block; | ||||||
width: 40px; | ||||||
height: 40px; | ||||||
} | ||||||
|
||||||
.header__list { | ||||||
list-style: none; | ||||||
margin: 0; | ||||||
padding: 0; | ||||||
display: flex; | ||||||
} | ||||||
|
||||||
.nav__item { | ||||||
margin-left: 20px; | ||||||
text-decoration: none; | ||||||
} | ||||||
|
||||||
.nav__item:first-child { | ||||||
margin-left: 0; | ||||||
} | ||||||
|
||||||
.nav__link.is-active { | ||||||
color: var(--main-color); | ||||||
} | ||||||
|
||||||
.nav__link { | ||||||
position: relative; | ||||||
display: flex; | ||||||
align-items: center; | ||||||
height: 60px; | ||||||
font-family: Roboto, sans-serif; | ||||||
font-size: 12px; | ||||||
font-weight: 500; | ||||||
white-space: nowrap; | ||||||
text-decoration: none; | ||||||
text-transform: uppercase; | ||||||
color: #000; | ||||||
} | ||||||
|
||||||
.nav__link:hover { | ||||||
color: var(--main-color); | ||||||
} | ||||||
|
||||||
.nav__link.is-active::after { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
content: ""; | ||||||
position: absolute; | ||||||
bottom: 0; | ||||||
left: 0; | ||||||
right: 0; | ||||||
height: 4px; | ||||||
border-radius: 2px; | ||||||
background-color: var(--main-color); | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix code style everywhere