add moyo header #4862
Open
add moyo header #4862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-denis718
commented
Apr 18, 2024
•
denis-denis718
commented
- DEMO LINK
- TEST REPORT LINK
anastasiiavorobiova
suggested changes
Apr 18, 2024
I don't understand what happens , when i open the correct version of this work, and mine, they are the same, but tests every time telling me it's not true... |
volodymyr-soltys97
suggested changes
May 4, 2024
src/index.html
Outdated
Comment on lines
38
to
40
| </a> | ||
| <nav class="nav"> |
There was a problem hiding this comment.
Suggested change
| </a> | |
| <nav class="nav"> | |
| </a> | |
| <nav class="nav"> |
src/index.html
Outdated
Comment on lines
48
to
51
| </li> | ||
| <li class="nav__item"> |
There was a problem hiding this comment.
Add the blank line between the links
Suggested change
| </li> | |
| <li class="nav__item"> | |
| </li> | |
| <li class="nav__item"> |
src/index.html
Outdated
Comment on lines
111
to
118
| <!-- <body> | ||
| <header class="navigation"> | ||
| <div class="navigation__wrapper"> | ||
| <div class="navigation__logo"> | ||
| <img | ||
| src="./images/logo.png" | ||
| alt="moyo_icon" | ||
| class="navbar-icon" |
src/style.css
Outdated
|
|
||
| padding: 0 50px; | ||
|
|
||
| background: #fff; |
There was a problem hiding this comment.
The default color
Suggested change
| background: #fff; |
src/style.css
Outdated
| } | ||
|
|
||
| .nav__link:hover { | ||
| color: #00acdc; |
There was a problem hiding this comment.
Create a variable for repeated color and use it everywhere
src/style.css
Outdated
Comment on lines
77
to
85
| /* body { | ||
| --primary-color: #00acdc; | ||
|
|
||
| margin: 0; | ||
| font-family: Roboto, sans-serif; | ||
| } | ||
|
|
||
| header { | ||
| display: block; |
There was a problem hiding this comment.
The same, remove all comments
etojeDenys
approved these changes
May 7, 2024
Comment on lines
+59
to
+65
| .nav__link:hover { | ||
| color: var(--main-color); | ||
| } | ||
|
|
||
| .nav__link.is-active { | ||
| color: var(--main-color); | ||
| } |
There was a problem hiding this comment.
Suggested change
| .nav__link:hover { | |
| color: var(--main-color); | |
| } | |
| .nav__link.is-active { | |
| color: var(--main-color); | |
| } | |
| .nav__link:hover, | |
| .nav__link.is-active { | |
| color: var(--main-color); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.