Develop #4870
Develop #4870
Conversation
maristella12
commented
Apr 22, 2024
maristella12
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Hello, @maristella12!
Great job 🎉
Just some points about the code. Can you please check?
Also, your style isn't being applied correctly as the reference.
Please check the comments and adjust your code to make sure that all is working correctly.
You can run npm run test before a new commit to check if is working correctly. Remember to check the reference and test and check if all tests pass.
src/style.css
Outdated
| } | ||
|
|
||
| /* Linha em branco antes da regra */ | ||
| .html { |
There was a problem hiding this comment.
You are trying to stylize a class that doesn't exists. Maybe is just html instead of .html?
| list-style-type: none; | ||
| display: flex; | ||
| align-items: end; | ||
|
|
There was a problem hiding this comment.
You can remove this blank line to keep the pattern on file.
src/index.html
Outdated
| </head> | ||
| <body> | ||
| <h1>Moyo header</h1> | ||
| <div class="logo"></div> | ||
| <div class="lista"> |
src/index.html
Outdated
| <div class="logo"></div> | ||
| <div class="lista"> | ||
| <ul> | ||
| <li> | ||
| <a href="#"> | ||
| <img | ||
| src="./images/logo.png" | ||
| alt="imagem da logo" | ||
| /> | ||
| </a> | ||
| </li> | ||
| <li><a href="#">APPLE</a></li> | ||
| <li><a href="#">SAMSUNG</a></li> | ||
| <li><a href="#">SMARTPHONES</a></li> | ||
| <li data-qa="hover"><a href="#">LAPTOPS & COMPUTERS</a></li> | ||
| <li><a href="#">GADGETS</a></li> | ||
| <li><a href="#">TABLETS</a></li> | ||
| <li><a href="#">PHOTO</a></li> | ||
| <li><a href="#"></a></li> | ||
| </ul> | ||
| </div> | ||
| <div class="is-active"></div> |
There was a problem hiding this comment.
Needs to be wrapped by a header tag.
src/index.html
Outdated
| <div class="logo"></div> | ||
| <div class="lista"> | ||
| <ul> | ||
| <li> | ||
| <a href="#"> | ||
| <img | ||
| src="./images/logo.png" | ||
| alt="imagem da logo" | ||
| /> | ||
| </a> | ||
| </li> | ||
| <li><a href="#">APPLE</a></li> | ||
| <li><a href="#">SAMSUNG</a></li> | ||
| <li><a href="#">SMARTPHONES</a></li> | ||
| <li data-qa="hover"><a href="#">LAPTOPS & COMPUTERS</a></li> | ||
| <li><a href="#">GADGETS</a></li> | ||
| <li><a href="#">TABLETS</a></li> | ||
| <li><a href="#">PHOTO</a></li> | ||
| <li><a href="#"></a></li> | ||
| </ul> | ||
| </div> | ||
| <div class="is-active"></div> |
There was a problem hiding this comment.
This div is not needed. You need to add the is-active class on a a tag on list. Like <a href="#" class="is-active">APPLE</a></li>
| align-items: center; | ||
| } | ||
|
|
||
| .nav { |
There was a problem hiding this comment.
I think that is just nav instead of .nav here too.
|
Já fiz as alterações recomendadas. |
|
Guilherme tá brabo ! Só consegui chegar até ai! |
There was a problem hiding this comment.
Hello, @maristella12!
Just a point about the readme. Please adjust into the comment too.
About your code, everything is fine now! Congratulations 🎉✨
Please remember to request a new review after adjust the README =)
readme.md
Outdated
| @@ -27,8 +27,8 @@ The page should match the design Pixel Perfect: all the sizes, colors and distan | |||
|
|
|||
| ❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description: | |||
|
|
|||
| - [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/) | |||
| - [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/) | |||
| - [DEMO LINK](https://tellabitt12.github.io/layout_moyo-header/) | |||
There was a problem hiding this comment.
Change to the correct Github User, link is not working
readme.md
Outdated
| - [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/) | ||
| - [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/) | ||
| - [DEMO LINK](https://tellabitt12.github.io/layout_moyo-header/) | ||
| - [TEST REPORT LINK](https://tellabitt12.github.io/layout_moyo-header/report/html_report/) |
There was a problem hiding this comment.
Change to the correct Github User, link is not working
|
Alterções do nome do usuário corrigidas. |
