Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #4900

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YaroslavMatviienko
Copy link

DEMO LINK

❗️ Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.

  • [+ ] Header height is set in 1 place (for the links)
  • [+] Content is vertically centered (for any header height)
  • [+] CSS is used to show all letters in Uppercase (don't type them in HTML)
  • [+] Logo is an image wrapped with a link
  • [+] CSS Variable is used for a blue color
  • [+] Pseudo-element is used for a blue line below the active link
  • [+] Code follows all the Code Style Rules ❗️

Copy link

@roman-mirzoian roman-mirzoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but there is still a lot of work to do.
Deployment does not work and tests fail. This needs to be fixed.
Pay attention to the comments.

image
image

src/style.css Outdated
font-family: Roboto, sans-serif, bold;
}

header {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use tag names for styling (except html and body)
Fix it in all code.

image

Copy link

@roman-mirzoian roman-mirzoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, but pay attention to this comments.

>
<img
src="images/logo.png"
alt="logo"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For logos, use the format: "[Organization name] logo."
Example:
image

Comment on lines +12 to +13
--black: #000;
--blue: #00acdc;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to use a more universal naming for such variables.

Suggested change
--black: #000;
--blue: #00acdc;
--text-color:: #000;
--active-color: #00acdc;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants