Develop #4904
Develop #4904
Conversation
src/style.css
Outdated
| @@ -1,3 +1,68 @@ | |||
| /* CSS variables */ | |||
There was a problem hiding this comment.
| /* CSS variables */ |
| } | ||
|
|
||
| .navigation-list { | ||
| display: flex; | ||
| margin: 0; |
There was a problem hiding this comment.
I didn’t understand what this was about. If I remove this margin, then show the standard from the browser from ul. No matter how I tried it, I can’t do without it))
Other comments have been corrected!
src/index.html
Outdated
| <link | ||
| rel="stylesheet" | ||
| href="./style.css" | ||
| /> | ||
| </head> | ||
| <body> | ||
| <h1>Moyo header</h1> | ||
| <header class="header"> | ||
| <div class="container"> |
There was a problem hiding this comment.
Excess wrapping. you can set styles for the header.
src/style.css
Outdated
| max-width: 1200px; | ||
| min-width: 780px; |
There was a problem hiding this comment.
Not hardcoded or using static dimensions.
It is better to set more flexible sizes, for example (max-width: 100%)
There was a problem hiding this comment.
Well done the code looks good, but you forgot to update the deploy demo.
The current demo does not match your code.
https://gyazo.com/c5ff805d1c5c86c7d1fa854e724d19d5
|
ОК. Good point! I didn't know about it. |
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️