Moyo Header #4908
Open
Moyo Header #4908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-mirzoian
suggested changes
May 2, 2024
src/index.html
Outdated
| > | ||
| <img | ||
| src="./images/logo.png" | ||
| alt="logo" |
There was a problem hiding this comment.
For logos, use the format: "[Organization name] logo."
Example:
src/style.css
Outdated
| margin-right: 50px; | ||
| } | ||
|
|
||
| .logo img { |
There was a problem hiding this comment.
Let`s use classes instead of tags as selectors.
src/style.css
Outdated
| } | ||
|
|
||
| body { | ||
| /* stylelint-disable-next-line font-family-name-quotes */ |
There was a problem hiding this comment.
Try to write the code so that it is not necessary to disable the linter.
added 2 commits
May 2, 2024 12:42
roman-mirzoian
suggested changes
May 3, 2024
src/index.html
Outdated
Comment on lines
29
to
46
| <li class="list_item"> | ||
| <a href="#" class="nav_link">Samsung</a> | ||
| </li> | ||
| <li class="list_item"> | ||
| <a href="#" class="nav_link">Smartphones</a> | ||
| </li> | ||
| <li class="list_item"> | ||
| <a href="#" data-qa="hover" class="nav_link">Laptops & Computers</a> | ||
| </li> | ||
| <li class="list_item"> | ||
| <a href="#" class="nav_link">Gadgets</a> | ||
| </li> | ||
| <li class="list_item"> | ||
| <a href="#" class="nav_link">Tablets</a> | ||
| </li> | ||
| <li class="list_item"> | ||
| <a href="#" class="nav_link">Photo</a> | ||
| </li> |
There was a problem hiding this comment.
Add empty lines between multiline sibling blocks of HTML
src/index.html
Outdated
Comment on lines
26
to
28
| <li class="list_item"> | ||
| <a href="#" class="nav_link is-active">Apple</a> | ||
| </li> |
There was a problem hiding this comment.
Keep your attributes correctly formatted.
Suggested change
| <li class="list_item"> | |
| <a href="#" class="nav_link is-active">Apple</a> | |
| </li> | |
| <li class="list_item"> | |
| <a | |
| href="#" | |
| class="nav_link is-active" | |
| > | |
| Apple | |
| </a> | |
| </li> |
There was a problem hiding this comment.
Yes, I knew that only 2 attributes in a single line are allowed. But the Prettier reduces everything to one attribute in a line. That's why I changed my formatter's default settings. But okay. I'll fix it the way you wish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️