Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moyo #4910

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

moyo #4910

wants to merge 3 commits into from

Conversation

DSB-18
Copy link

@DSB-18 DSB-18 commented Apr 30, 2024

I forgot to create develop branch. Is it still needed?

  • DEMO LINK

  • TEST REPORT LINK

  • Header height is set in 1 place (for the links)

  • Content is vertically centered (for any header height)

  • CSS is used to show all letters in Uppercase (don't type them in HTML)

  • Logo is an image wrapped with a link

  • CSS Variable is used for a blue color

  • Pseudo-element is used for a blue line below the active link

  • Code follows all the Code Style Rules ❗️

Copy link

@dinaminahi dinaminahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍
Look through some advices below

src/style.css Outdated
@@ -1,3 +1,80 @@
body {
* {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better not to use * selector, you can set this on those elements you need
image

src/style.css Outdated
font-family: Roboto, sans-serif;
font-size: 12px;
font-weight: 500;
font-style: normal;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-style: normal;

It is default value

src/style.css Outdated
color: #000;
align-items: center;
height: 60px;
line-height: 60px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
line-height: 60px;

no need in this, it will still work

src/style.css Outdated
justify-content: space-between;
padding: 0 50px;
align-items: center;
line-height: 60px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Suggested change
line-height: 60px;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants