Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add moyo header New fork #4928

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

pvnovikova
Copy link

DEMO LINK
TEST REPORT LINK
[x] Header height is set in 1 place (for the links)
[x] Content is vertically centered (for any header height)
[x] CSS is used to show all letters in Uppercase (don't type them in HTML)
[x] Logo is an image wrapped with a link
[x] CSS Variable is used for a blue color
[x] Pseudo-element is used for a blue line below the active link
[x] Code follows all the Code Style Rules ❗️

@pvnovikova pvnovikova mentioned this pull request May 6, 2024
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines +67 to +73
.nav__link:hover {
color: var(--active-color);
}

.nav__link.is-active {
color: var(--active-color);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.nav__link:hover {
color: var(--active-color);
}
.nav__link.is-active {
color: var(--active-color);
}
.nav__link:hover,
.nav__link.is-active {
color: var(--active-color);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants