add task solution #4932
Open
add task solution #4932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitlherme
suggested changes
May 8, 2024
src/index.html
Outdated
Comment on lines
32
to
114
| <header class="header"> | ||
| <a | ||
| href="#Home" | ||
| class="image" | ||
| > | ||
| <img | ||
| class="imageLogo" | ||
| src="images/logo.png" | ||
| alt="logo Moyo" | ||
| /> | ||
| </a> | ||
| <nav class="nav"> | ||
| <ul class="nav_list"> | ||
| <li class="nav_li"> | ||
| <a | ||
| href="#" | ||
| class="link is-active" | ||
| > | ||
| Apple | ||
| </a> | ||
| </li> | ||
| <li class="nav_li"> | ||
| <a | ||
| href="#" | ||
| class="link" | ||
| > | ||
| Samsung | ||
| </a> | ||
| </li> | ||
| <li class="nav_li"> | ||
| <a | ||
| href="#" | ||
| class="link" | ||
| > | ||
| Smartphones | ||
| </a> | ||
| </li> | ||
| <li | ||
| class="nav_li" | ||
| data-qa="hover" | ||
| > | ||
| <a | ||
| href="#" | ||
| class="link" | ||
| > | ||
| Laptops & Computers | ||
| </a> | ||
| </li> | ||
| <li class="nav_li"> | ||
| <a | ||
| href="#" | ||
| class="link" | ||
| > | ||
| Gadgets | ||
| </a> | ||
| </li> | ||
| <li class="nav_li"> | ||
| <a | ||
| href="#" | ||
| class="link" | ||
| > | ||
| Tablets | ||
| </a> | ||
| </li> | ||
| <li class="nav_li"> | ||
| <a | ||
| href="#" | ||
| class="link" | ||
| > | ||
| Photo | ||
| </a> | ||
| </li> | ||
| <li class="nav_li"> | ||
| <a | ||
| href="#" | ||
| class="link" | ||
| > | ||
| Video | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| </nav> | ||
| </header> |
There was a problem hiding this comment.
Hello, @jonathanhora!
Remember to keep the BEM rules here. Instead of image on line 36 and imageLogo on line 38, you can use header__logo and header__image for example.
The same for the links, instead of nav_li and link, try to use nav__item and nav__link. You can also change nav_list to nav__list.
Comment on lines
+2
to
+4
| --font-texto-padrao: 'Roboto', sans-serif; | ||
| --cor-texto-padrao: #000; | ||
| --cor-ative: #00acdc; |
There was a problem hiding this comment.
Change to english to keep the pattern on all code.
You can change to --default-text-font, --default-text-color and --active-color for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️