Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5323

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Develop #5323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b92e5b6
moyo header task
Aug 29, 2024
b0c29f4
changes css
Aug 30, 2024
75c051c
changes css
Aug 30, 2024
ab4cfb2
changes css
Aug 30, 2024
bbb8421
change according to PR comment
Aug 30, 2024
6899592
changes css
Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ The page should match the design Pixel Perfect: all the sizes, colors and distan

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/)
- [DEMO LINK](https://ievgen-nikiforov.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://ievgen-nikiforov.github.io/layout_moyo-header/report/html_report/)
ievgen-nikiforov marked this conversation as resolved.
Show resolved Hide resolved

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
89 changes: 88 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,100 @@
http-equiv="X-UA-Compatible"
content="ie=edge"
/>

<title>Moyo header</title>
<link
href="https://fonts.googleapis.com/css2?family=Roboto:wght@500&display=swap"
rel="stylesheet"
/>
<link
rel="stylesheet"
href="./style.css"
/>
</head>
<header class="header">
<a
href="#home"
class="header__link"
>
<img
class="img"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class="img"
class="header__img"

src="./images/logo.png"
alt="moyo_logo"
/>
</a>
<nav class="nav">
Comment on lines +34 to +35
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</a>
<nav class="nav">
</a>
<nav class="nav">

<ul class="nav__list">
<li class="nav__item">
<a
href="#"
class="nav__link is-active"
>
Apple
</a>
</li>
<li class="nav__item">
Comment on lines +44 to +45
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the blank line between the links

Suggested change
</li>
<li class="nav__item">
</li>
<li class="nav__item">

<a
href="#"
class="nav__link"
>
Samsung
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Smartphones
</a>
</li>
<li class="nav__item">
<a
href="#"
data-qa="hover"
class="nav__link"
>
Laptops & Computers
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Gadgets
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Tablets
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Photo
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Video
</a>
</li>
</ul>
</nav>
</header>

<body>
<h1>Moyo header</h1>

</body>
</html>
91 changes: 90 additions & 1 deletion src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,92 @@
body {
:root {
--accent-color: #00acdc;
}

body,
.nav__list {
margin: 0;
font-family: Roboto, sans-serif;
font-weight: 500;
}

.img {
width: 40px;
height: 40px;
}

.header {
padding: 0 50px;
display: flex;
justify-content: space-between;
flex-direction: row;
}

.nav {
display: flex;
justify-content: space-between;
align-items: center;
}

.nav__item {
height: 60px;
list-style-type: none;
display: flex;
position: relative;
margin: 0 10px;
}

.nav__item:last-child {
margin-right: 0;
}

.nav__item:first-child {
margin-left: 0;
}

.nav__link {
height: 100%;
text-decoration: none;
text-transform: uppercase;
color: #000;
font-weight: 500;
font-size: 12px;
display: flex;
align-items: center;
line-height: 15px;
}

.nav__link:hover,
.is-active {
color: var(--accent-color);
}

.nav__list {
height: 100%;
display: flex;
flex-direction: row;
justify-content: space-between;
align-items: center;
margin: 0;
padding: 0;
}

.is-active {
position: relative;
}

.is-active::after {
content: '';
position: absolute;
left: 0;
bottom: 0;
width: 100%;
height: 4px;
background-color: var(--accent-color);
border-radius: 8px;
}

.header__link {
display: flex;
align-items: center;
height: 60px;
}
Loading