-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5325
base: master
Are you sure you want to change the base?
add task solution #5325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Let's make your code better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had troubles with deploy after changes. I'm using Ubuntu. And after few efforts with 14 version of node, I deployed gh-pages on 18 version. But previously I was using 14.21.3 node... Don't understand the reason of my issue. But now gh-pages are redeployed. I hope, everything is ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
DEMO LINK
TEST REPORT LINK
[X ] Header height is set in 1 place (for the links)
[X ] Content is vertically centered (for any header height)
[X ] CSS is used to show all letters in Uppercase (don't type them in HTML)
[X ] Logo is an image wrapped with a link
[X ] CSS Variable is used for a blue color
[X ] Pseudo-element is used for a blue line below the active link
[X ] Code follows all the Code Style Rules ❗️