ready to push #5332

MindControl01 · 2024-09-02T21:36:24Z

No description provided.

volodymyr-soltys97

Hi, there is no demo link, you need to add demo link to the PR description

volodymyr-soltys97 · 2024-09-03T06:08:05Z

src/index.html

  </head>
  <body>
-    <h1>Moyo header</h1>
+    <!--Header start-->


Suggested change

volodymyr-soltys97 · 2024-09-03T06:08:21Z

src/index.html

+      <div class="wrapper">
+        <div class="header__wrapper">


Redundant

Suggested change

<div class="wrapper">

<div class="header__wrapper">

volodymyr-soltys97 · 2024-09-03T06:08:28Z

src/index.html

  </head>
  <body>
-    <h1>Moyo header</h1>
+    <!--Header start-->
+    <header class="header__menu">


Suggested change

<header class="header__menu">

<header class="header">

volodymyr-soltys97 · 2024-09-03T06:09:46Z

src/index.html

+                  <a href="#!" class="header__logo-link">
+                  <img src="./images/logo.png" alt="MOYO logo" class="header__logo-pic">
+                  </a>


Fix code style everywhere

Suggested change

<a href="#!" class="header__logo-link">

<img src="./images/logo.png" alt="MOYO logo" class="header__logo-pic">

</a>

<a href="#" class="header__link">

<img

src="./images/logo.png"

alt="MOYO logo"

class="header__img"

>

</a>

volodymyr-soltys97 · 2024-09-03T06:10:42Z

src/index.html

+                <li class="header__item">
+                        <a href="#Apple" class="header__link js-scroll is-active">Apple</a>
+                </li>


Suggested change

<li class="header__item">

<a href="#Apple" class="header__link js-scroll is-active">Apple</a>

</li>

<li class="header__item">

<a href="#Apple" class="nav__link is-active">Apple</a>

</li>

volodymyr-soltys97 · 2024-09-03T06:11:16Z

src/index.html

+
+          <nav class="header__nav">
+            <ul class="header__list">
+                <li class="header__item">


Fix classes everywhere

Suggested change

<nav class="header__nav">

<ul class="header__list">

<li class="header__item">

<nav class="nav">

<ul class="nav__list">

<li class="nav__item">

src/index.html

etojeDenys

please, provide the links from the readme.md file, or feel free to ask for some help in the chat

MindControl01 · 2024-10-27T22:28:07Z

But I already provided this links, we talk about Demolinks and Test report link? чт, 24 окт. 2024 г. в 22:09, Denys Semtso ***@***.***>:

…

***@***.**** requested changes on this pull request. please, provide the links from the readme.md file, or feel free to ask for some help in the chat — Reply to this email directly, view it on GitHub <#5332 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARIHFALVP5NM4NDTTCPAKTTZ5FHWDAVCNFSM6AAAAABNQ5OBJKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJTGYYTIMRVG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

…-header into header

MindControl01 · 2024-12-26T15:44:28Z

volodymyr-soltys97

Hi, these links are wrong now, you need to fix it and update it

Also, your demo link isn't working, you need to make a deploy and check after the demo

volodymyr-soltys97 · 2024-12-26T15:48:24Z

readme.md

+- [DEMO LINK](https://https://github.com/MindControl01.github.io/layout_moyo-header/)
+- [TEST REPORT LINK](https://https://github.com/MindControl01.github.io/layout_moyo-header/report/html_report/)


Suggested change

- [DEMO LINK](https://https://github.com/MindControl01.github.io/layout_moyo-header/)

- [TEST REPORT LINK](https://https://github.com/MindControl01.github.io/layout_moyo-header/report/html_report/)

- [DEMO LINK](https://MindControl01.github.io/layout_moyo-header/)

- [TEST REPORT LINK](https://MindControl01.github.io/layout_moyo-header/report/html_report/)

volodymyr-soltys97 · 2024-12-26T15:49:26Z

src/index.html

  </head>
  <body>
-    <h1>Moyo header</h1>
+    <header class="header">
+      <div class="wrapper">


Redundant wrapper

Suggested change

<div class="wrapper">

volodymyr-soltys97 · 2024-12-26T15:50:10Z

src/index.html

+            <li class="nav__item">
+              <a
+                href="#Samsung"
+                class="nav__link is-active"


This class should be only for first link, remove it everywhere

Suggested change

class="nav__link is-active"

class="nav__link"

I thought this function on the first element in figma show us how should work all buttons after hovering over them

volodymyr-soltys97 · 2024-12-26T15:50:43Z

src/style.css

+
+  /* Header start */
+
+  active-color {


Need to create variable with :root selector

Suggested change

active-color {

:root {

volodymyr-soltys97 · 2024-12-26T15:50:57Z

src/style.css

+    display: flex;
+    justify-content: center;
+    align-items: center;
+    position: fixed;


Redundant

Suggested change

position: fixed;

volodymyr-soltys97 · 2024-12-26T15:51:05Z

src/style.css

+  }
+
+  .nav {
+    width: 1200px;


Suggested change

width: 1200px;

volodymyr-soltys97 · 2024-12-26T15:51:11Z

src/style.css

+    align-items: flex-end;
+    color: black;
+    list-style-type: none;
+    padding-left: 420px;


Suggested change

padding-left: 420px;

volodymyr-soltys97 · 2024-12-26T15:51:36Z

src/style.css

+  }
+
+  [data-qa='hover'] {
+    color: #00acdc;


Use a variable for repeated color

MindControl01 · 2025-01-04T15:48:13Z

MindControl01 · 2025-01-04T15:49:10Z

Я не могу понять почему Test Report link не работает, уже всё перепробовал. Деплой сделал/

Another comments was successfuly debugged

anastasiiavorobiova

Try to fix repo settings and pick the gh-pages as the deploy branch
Or you can fork and clone the repo one more time to rerun the deploy script

ready to push

c32ee1d

volodymyr-soltys97 suggested changes Sep 3, 2024

View reviewed changes

Max Bolotskyi and others added 2 commits September 16, 2024 00:09

debugged

250a891

Merge branch 'master' into header

302fc5c

MindControl01 requested a review from volodymyr-soltys97 October 24, 2024 20:05

etojeDenys suggested changes Oct 24, 2024

View reviewed changes

Max Bolotskyi added 3 commits December 26, 2024 16:07

ready to check

213090c

r

117d131

Merge branch 'header' of https://github.com/MindControl01/layout_moyo…

d90940a

…-header into header

MindControl01 requested a review from etojeDenys December 26, 2024 15:44

volodymyr-soltys97 suggested changes Dec 26, 2024

View reviewed changes

Max Bolotskyi added 2 commits January 4, 2025 16:02

debugged

873a7d2

debugged demolink

dce00e8

MindControl01 requested a review from volodymyr-soltys97 January 5, 2025 00:24

anastasiiavorobiova suggested changes Jan 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ready to push #5332

ready to push #5332

MindControl01 commented Sep 2, 2024

volodymyr-soltys97 left a comment

volodymyr-soltys97 Sep 3, 2024

volodymyr-soltys97 Sep 3, 2024

volodymyr-soltys97 Sep 3, 2024

volodymyr-soltys97 Sep 3, 2024

volodymyr-soltys97 Sep 3, 2024

volodymyr-soltys97 Sep 3, 2024

etojeDenys left a comment

MindControl01 commented Oct 27, 2024 via email

MindControl01 commented Dec 26, 2024

volodymyr-soltys97 left a comment

volodymyr-soltys97 Dec 26, 2024

volodymyr-soltys97 Dec 26, 2024

volodymyr-soltys97 Dec 26, 2024

MindControl01 Jan 1, 2025

volodymyr-soltys97 Dec 26, 2024

volodymyr-soltys97 Dec 26, 2024

volodymyr-soltys97 Dec 26, 2024

volodymyr-soltys97 Dec 26, 2024

volodymyr-soltys97 Dec 26, 2024

MindControl01 commented Jan 4, 2025

MindControl01 commented Jan 4, 2025 •

edited

Loading

anastasiiavorobiova left a comment

		- [DEMO LINK](https://https://github.com/MindControl01.github.io/layout_moyo-header/)
		- [TEST REPORT LINK](https://https://github.com/MindControl01.github.io/layout_moyo-header/report/html_report/)

ready to push #5332

Are you sure you want to change the base?

ready to push #5332

Conversation

MindControl01 commented Sep 2, 2024

volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etojeDenys left a comment

Choose a reason for hiding this comment

MindControl01 commented Oct 27, 2024 via email

MindControl01 commented Dec 26, 2024

volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MindControl01 commented Jan 4, 2025

MindControl01 commented Jan 4, 2025 • edited Loading

anastasiiavorobiova left a comment

Choose a reason for hiding this comment

MindControl01 commented Jan 4, 2025 •

edited

Loading