add task solution #5337
Open
add task solution #5337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiiavorobiova
suggested changes
Sep 5, 2024
src/style.css
Outdated
| } | ||
|
|
||
| .logo-image { | ||
| margin: 10px 50px; |
There was a problem hiding this comment.
Suggested change
| margin: 10px 50px; | |
| margin: 10px 0; |
| .header { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; |
There was a problem hiding this comment.
Suggested change
| justify-content: space-between; | |
| justify-content: space-between; | |
| padding: 0 50px; |
| } | ||
|
|
||
| .li_nav { | ||
| margin-right: 20px; |
There was a problem hiding this comment.
Consider removing the margin right for the last child
volodymyr-soltys97
suggested changes
Sep 6, 2024
src/index.html
Outdated
| class="logo" | ||
| > | ||
| <img | ||
| src="images/moyo_1.png" |
There was a problem hiding this comment.
You already have this image
Suggested change
| src="images/moyo_1.png" | |
| src="images/moyo.png" |
src/index.html
Outdated
Comment on lines
30
to
31
| </a> | ||
| <nav class="nav"> |
There was a problem hiding this comment.
Suggested change
| </a> | |
| <nav class="nav"> | |
| </a> | |
| <nav class="nav"> |
src/index.html
Outdated
Comment on lines
32
to
33
| <ul class="ul__nav"> | ||
| <li class="li_nav"> |
There was a problem hiding this comment.
Fix classes everywhere
Suggested change
| <ul class="ul__nav"> | |
| <li class="li_nav"> | |
| <ul class="nav__list"> | |
| <li class="nav__item"> |
src/index.html
Outdated
Comment on lines
40
to
41
| </li> | ||
| <li class="li_nav"> |
There was a problem hiding this comment.
Add the blank line between the links
Suggested change
| </li> | |
| <li class="li_nav"> | |
| </li> | |
| <li class="li_nav"> |
src/style.css
Outdated
| @@ -1,3 +1,70 @@ | |||
| body { | |||
| margin: 0; | |||
| padding: 0; | |||
There was a problem hiding this comment.
The body hasn't a padding
Suggested change
| padding: 0; |
src/style.css
Outdated
Comment on lines
7
to
8
| margin: 0; | ||
| padding: 0; |
There was a problem hiding this comment.
Suggested change
| margin: 0; | |
| padding: 0; |
src/style.css
Outdated
| padding: 0; | ||
| font-family: Roboto, sans-serif; | ||
|
|
||
| --active-color: #00acdc; |
There was a problem hiding this comment.
Create a variable with :root selector
src/style.css
Outdated
| color: #000; | ||
| font-size: 12px; | ||
| font-weight: 500; | ||
| text-align: left; |
There was a problem hiding this comment.
Default
Suggested change
| text-align: left; |
etojeDenys
approved these changes
Sep 6, 2024
Comment on lines
+52
to
+58
| .nav__link:hover { | ||
| color: var(--active-color); | ||
| } | ||
|
|
||
| .is-active { | ||
| color: var(--active-color); | ||
| } |
There was a problem hiding this comment.
Suggested change
| .nav__link:hover { | |
| color: var(--active-color); | |
| } | |
| .is-active { | |
| color: var(--active-color); | |
| } | |
| .nav__link:hover, | |
| .is-active { | |
| color: var(--active-color); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️
DEMO LINK
TEST REPORT LINK