Develop #5346
Closed
Develop #5346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiiavorobiova
suggested changes
Sep 9, 2024
src/style.css
Outdated
Comment on lines
79
to
85
| a[data-qa]:hover { | ||
| color: #00acdc; | ||
| } | ||
|
|
||
| /* [data-qa='hover'] { | ||
| color: #00acdc; | ||
| } */ |
There was a problem hiding this comment.
Suggested change
| a[data-qa]:hover { | |
| color: #00acdc; | |
| } | |
| /* [data-qa='hover'] { | |
| color: #00acdc; | |
| } */ |
src/style.css
Outdated
| } | ||
|
|
||
| .is-active::after { | ||
| color: #00acdc; |
There was a problem hiding this comment.
Consider using variables for repeating colors
RareHelix
commented
Sep 9, 2024
volodymyr-soltys97
suggested changes
Sep 9, 2024
src/index.html
Outdated
Comment on lines
42
to
23
| </a> | ||
| <nav class="nav"> |
There was a problem hiding this comment.
Suggested change
| </a> | |
| <nav class="nav"> | |
| </a> | |
| <nav class="nav"> |
src/index.html
Outdated
Comment on lines
52
to
31
| </li> | ||
| <li class="nav__item"> |
There was a problem hiding this comment.
Add the blank line between the links
Suggested change
| </li> | |
| <li class="nav__item"> | |
| </li> | |
| <li class="nav__item"> |
src/style.css
Outdated
Comment on lines
5
to
7
| html { | ||
| margin: 0; | ||
| } |
There was a problem hiding this comment.
Suggested change
| html { | |
| margin: 0; | |
| } |
src/style.css
Outdated
Comment on lines
83
to
85
| a[data-qa]:hover { | ||
| color: var(--main-color); | ||
| } |
There was a problem hiding this comment.
Suggested change
| a[data-qa]:hover { | |
| color: var(--main-color); | |
| } |
src/style.css
Outdated
Comment on lines
75
to
70
| a.is-active { | ||
| color: var(--main-color); | ||
| } |
There was a problem hiding this comment.
Suggested change
| a.is-active { | |
| color: var(--main-color); | |
| } |
etojeDenys
suggested changes
Sep 9, 2024
src/style.css
Outdated
Comment on lines
5
to
7
| html { | ||
| margin: 0; | ||
| } |
src/style.css
Outdated
Comment on lines
75
to
70
| a.is-active { | ||
| color: var(--main-color); | ||
| } |
src/style.css
Outdated
Comment on lines
83
to
85
| a[data-qa]:hover { | ||
| color: var(--main-color); | ||
| } |
etojeDenys
suggested changes
Sep 10, 2024
volodymyr-soltys97
suggested changes
Sep 10, 2024
|
I make changes and write, but they are not saved for some reason
вт, 10 вер. 2024 р. о 11:02 Volodymyr Soltys ***@***.***>
пише:
… ***@***.**** requested changes on this pull request.
Hi, you need to fix all comments from the previous review, if you need
help feel free in the fe_chat
—
Reply to this email directly, view it on GitHub
<#5346 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BH4X7TNMODD5D2UFEE7BBATZV2RQDAVCNFSM6AAAAABN4SK7ECVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOJRGY3TAMRSG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
anastasiiavorobiova
approved these changes
Sep 10, 2024
| text-transform: uppercase; | ||
| } | ||
|
|
||
| .nav_list:first-child { |
There was a problem hiding this comment.
Suggested change
| .nav_list:first-child { | |
| .nav__item:first-child { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height). - [x]
CSS is used to show all letters in Uppercase (don't type them in HTML) - [x]
Logo is an image wrapped with a link - [x]
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link - [x]
Code follows all the [Code Style Rules ❗️] - x