-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #5360
Develop #5360
Conversation
Krrampuss
commented
Sep 14, 2024
•
edited
Loading
edited
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 Great job on the progress so far! We just need to address a few important points before we can approve the Pull Request. Specifically, let's work on the formatting and semantics of the code. Correctly structuring the href
attributes, improving readability with proper indentation and spacing, and using more meaningful class names will significantly enhance the quality of your code. Keep up the good work, and with these changes, your code will be in tip-top shape! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 👍
Left a few comments. Remove duplicated files, also fix links to demo and test report as now they are just point to your repository instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.