-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5731
add task solution #5731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can proceed:
-
Semantic HTML: The HTML structure does not fully utilize semantic tags, which is crucial for accessibility and SEO. For instance, navigation items should be implemented using
<ul>
and<li>
tags instead of<div>
. -
Logo Link: The
href
attribute in the<a>
tag for the logo is incorrectly pointing to an image file instead of a valid URL or anchor link. This needs to be corrected to ensure proper navigation. -
CSS Variable: The requirement specifies using a CSS variable for the blue color, but the code uses a hardcoded color value. This needs to be addressed to meet the task requirements.
-
Crossorigin Attribute: The
crossorigin
attribute is set to '0', which is not valid. It should be either 'anonymous' or 'use-credentials'.
These issues are important for the functionality and compliance with the task requirements. Please make these changes, and feel free to reach out if you need any help! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
<a | ||
href="images/logo.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href
attribute in the <a>
tag is pointing to an image file (images/logo.png
). Typically, the href
attribute should point to a URL or a page within the site. If this is intended to be a link to another page, you should update the href
to the correct URL.
<link | ||
rel="preconnect" | ||
href="https://fonts.gstatic.com" | ||
crossorigin="0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The crossorigin
attribute is set to '0', which is not a valid value. It should be either 'anonymous' or 'use-credentials'. Please update this attribute to a valid value.
src/style.css
Outdated
text-decoration: none; | ||
} | ||
|
||
.a.is-active { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The selector .a.is-active
seems incorrect. It should be a.is-active
without the dot before a
, as you are targeting an <a>
tag with the class is-active
. Please correct this to ensure the styles are applied properly.
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️