Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5736

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #5736

wants to merge 2 commits into from

Conversation

Viktor-1995
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great effort on your submission! 🎉 Your code meets most of the task requirements and constraints, which is a solid step forward. However, there are a few areas that need attention to enhance your code quality:

  1. CSS Improvements:

    • Avoid using tag names like ul, li, and a for styling. Instead, use class names to adhere to best practices and checklist requirements.
  2. HTML Adjustments:

    • Update the href attributes in the <a> tags to use anchor links starting with the # symbol, as specified in the checklist.
    • Ensure the alt attribute for images is descriptive of the image content to improve accessibility and meet checklist standards.
  3. General Observations:

    • You've correctly implemented the CSS variable for the blue color and used a pseudo-element for the blue line below the active link.
    • The data-qa="hover" attribute is correctly added to the 4th link, which is great!

The decision to APPROVE is made to help you progress in your learning journey. Please review the comments and address these issues to improve your code. Remember, addressing these points will not only help you meet the task requirements but also enhance your coding skills. Keep up the good work and continue learning from these experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants