Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #5756

Closed
wants to merge 8 commits into from
Closed

Conversation

Elvira-Bariieva
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your hard work on this pull request! 😊 While your code meets many of the task requirements, there are a few critical issues that need to be addressed before we can approve it:

  1. CSS Variable Definition: The var(--main-color) is used but not defined in your CSS file. Please define it within a :root selector or ensure it's defined elsewhere in your styles to avoid any potential issues with styling.

  2. Box-Sizing Consistency: The box-sizing property is currently applied only to the body. It's best practice to apply this to all elements using the universal selector * to ensure consistent box-sizing across the entire page.

  3. Navigation Links: The href attributes for the navigation links are set to #, which is a placeholder. These should be replaced with actual URLs or meaningful link destinations to ensure proper navigation functionality.

These changes are important to ensure the functionality and maintainability of your code. Once you've made these updates, feel free to resubmit your pull request. Keep up the great work, and don't hesitate to reach out if you have any questions! 🌟

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
@Elvira-Bariieva Elvira-Bariieva deleted the develop branch December 5, 2024 14:50
Copy link
Author

@Elvira-Bariieva Elvira-Bariieva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't find any other issues

@Elvira-Bariieva Elvira-Bariieva restored the develop branch December 5, 2024 15:03
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls, if you have some issues don't hesitate to ask for some help in the chat

@Elvira-Bariieva Elvira-Bariieva deleted the develop branch December 10, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants