Develop #5789
Develop #5789
Conversation
veneracode
commented
Dec 8, 2024
veneracode
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 While you've made great progress, there are a few critical issues that need to be addressed to fully meet the task requirements:
-
CSS Variable for Blue Color: The task requires using a CSS variable for the blue color, which is currently missing. This is important for maintainability and consistency across your styles.
-
Header Height: The height should be set for the links, not the header itself. This affects the layout and needs to be corrected to meet the task specifications.
-
Multiple 'is-active' Classes: Having multiple elements with the
is-activeclass can lead to confusion if it's meant to indicate a single active item. Ensure only one element has this class to accurately represent the active state.
These issues impact the core requirements of the task, so please address them. Once resolved, your code will be in great shape! Keep up the good work, and don't hesitate to reach out if you need any help. 🌟
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
There was a problem hiding this comment.
Great job on addressing most of the issues! 🎉 The CSS variable for the blue color is correctly implemented, and the height is now set for the links, aligning with the task requirements. However, the issue with multiple elements having the is-active class persists. Please ensure that only one element has this class if it's meant to indicate a single active item. This will help accurately represent the active state and improve the functionality of your code. Keep up the good work and continue to refine your skills by addressing these points in future projects. Your efforts are appreciated, and this decision is made to help you move forward with your learning journey. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/index.html
Outdated
| class="box apple is-active" | ||
| > | ||
| APPLE | ||
| </a> | ||
| </li> | ||
| <li> | ||
| <a | ||
| href="#sams" | ||
| class="box samsung is-active" |
There was a problem hiding this comment.
There are multiple elements with the is-active class. If this class is intended to indicate a single active item, ensure only one element has this class to accurately represent the active state.
| height: 60px; /* Висота посилання */ | ||
| line-height: 60px; /* Вирівнювання тексту вертикально */ |
There was a problem hiding this comment.
The height is correctly set for the links, which aligns with the task requirements. Ensure that this is consistently applied across all relevant elements.
