add task solution #5799
add task solution #5799
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 🌟 While your solution meets most of the task requirements, there's a critical issue with the image source path that needs to be addressed. The use of backslashes (\) instead of forward slashes (/) in the image path can cause the images not to load correctly in web environments. Please update the image paths to use forward slashes to ensure compatibility across all browsers. Once this is fixed, your code will be ready to go! Keep up the great work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| class="logo_img" | ||
| > | ||
| <img | ||
| src="images\logo.png" |
There was a problem hiding this comment.
The image source path uses a backslash (\), which is incorrect for web URLs. It should be a forward slash (/) to ensure the image loads correctly across all browsers. Change images\logo.png to images/logo.png.
There was a problem hiding this comment.
Great job on addressing the previous issues! 🎉 Your HTML and CSS files are well-structured and meet the task requirements. The use of semantic tags and CSS variables is commendable. The critical issue with the image path has been resolved by using forward slashes, ensuring compatibility across all browsers.
Please remember to always use forward slashes in image paths to avoid loading issues. Keep up the good work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| class="logo_img" | ||
| > | ||
| <img | ||
| src="images/logo.png" |
There was a problem hiding this comment.
The image source path uses backslashes (\) instead of forward slashes (/). Update the path to use forward slashes to ensure compatibility across all browsers.
DEMO LINK
TEST REPORT LINK
Copy this
Checklistto thePull Requestdescription after links, and put- [x]before each point after you checked it.Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️