create header #5810
create header #5810
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 There are a couple of critical issues that need to be addressed before we can approve the pull request. Specifically, there are typos in the href attributes that could lead to broken links:
- The
hrefattribute value'#viideo'should be corrected to'#video'to properly reference the ID on the page. - The
hrefattribute value'laptops&computers'is missing a'#'at the beginning. It should be'#laptops&computers'to correctly reference the ID on the page.
Once these are fixed, your code will meet the core requirements of the task. Keep up the great work, and feel free to reach out if you have any questions! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="laptops&computers" |
There was a problem hiding this comment.
The href attribute value 'laptops&computers' is missing a '#' at the beginning. It should be '#laptops&computers' to correctly reference an ID on the page.
src/index.html
Outdated
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#viideo" |
There was a problem hiding this comment.
There is a typo in the href attribute value '#viideo'. It should be '#video' to correctly reference an ID on the page.
There was a problem hiding this comment.
Great job on addressing the previous issues with the href attributes in your HTML file! 🎉 The href for #video is now correct. However, please ensure that the href for #laptops&computers includes the # symbol at the beginning to ensure the link functions properly. Your CSS file is well-structured and uses CSS variables effectively, which is a good practice.
The code now meets the task requirements and constraints as specified. Remember to review the comments to improve your code further. Addressing these minor issues will help you avoid similar problems in the future. Keep up the good work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <a | ||
| href="#laptops&computers" |
There was a problem hiding this comment.
The href attribute value 'laptops&computers' is missing a '#' at the beginning. It should be '#laptops&computers' to correctly reference the ID on the page.
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️