Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5832

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #5832

wants to merge 3 commits into from

Conversation

AQingZeo
Copy link

Checklist:

  • Header height is set in 1 place (for the links)
  • Content is vertically centered (for any header height)
  • CSS is used to show all letters in Uppercase (don't type them in HTML)
  • Logo is an image wrapped with a link // no link for reference I didn't add href in the link
  • CSS Variable is used for a blue color
  • Pseudo-element is used for a blue line below the active link
  • Code follows all the Code Style Rules ❗️ //few styles are automatically changed when running in VScode

More comments:
In test the line beneath "APPLE" does not match perfectly with the sample but I don't know how to change it
In test there is extra space after "VIDEO", but I checked the figma file the space after VIDEO should only be the 50px padding (for the header)

Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants