Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution new #5834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution new #5834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ The page should match the design Pixel Perfect: all the sizes, colors and distan

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/)
- [DEMO LINK](https://kondratiukD.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://kondratiukD.github.io/layout_moyo-header/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
3 changes: 3 additions & 0 deletions src/images/Rectangle 2.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
76 changes: 75 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,82 @@
rel="stylesheet"
href="./style.css"
/>
<link
rel="preconnect"
href="https://fonts.googleapis.com"
/>
<link
rel="preconnect"
href="https://fonts.gstatic.com"
crossorigin="anonymous"
/>
<link
href="https://fonts.googleapis.com/css2?family=Play&family=Roboto+Condensed:wght@500&family=Roboto:wght@500&display=swap"
rel="stylesheet"
/>
</head>
<body>
<h1>Moyo header</h1>
<header>
<div class="navigation">
<a href="#">
<img
class="img"
alt="logo"
src="./images/logo.png"
/>
</a>
<nav class="nav-bar">
<a
href="#"
class="link is-active"
>
Apple
</a>
<a
href="#"
class="link"
>
Samsung
</a>
<a
href="#"
class="link"
>
Smartphones
</a>
<a
href="#"
class="link hover"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'hover' class is applied to the 'Laptops & Computers' link. Ensure that this class is defined in your CSS and is intended for this specific link. If it is meant to be a hover effect for all links, consider applying it consistently across all navigation links.

data-qa="hover"
>
Laptops & Computers
</a>
<a
href="#"
class="link"
>
Gadgets
</a>
<a
href="#"
class="link"
>
Tablets
</a>
<a
href="#"
class="link"
>
Photo
</a>
<a
href="#"
class="link"
>
Video
</a>
</nav>
</div>
</header>
</body>
</html>
59 changes: 59 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,62 @@
:root {
--blue-color: #00acdc;
}

body {
margin: 0;
font-family: Roboto, serif;
font-size: 12px;
font-weight: 500;
font-style: normal;
}

.link {
display: flex;
color: black;
text-decoration: none;
text-transform: uppercase;
align-items: center;
height: 100%;
white-space: nowrap;
}

a.link.is-active {
color: var(--blue-color) !important;
text-decoration: none;
background-image: url(./images/Rectangle\ 2.svg);
background-repeat: no-repeat;

background-position: bottom center;
background-size: contain;
}

a.link.is-active:hover,
a.link.hover:hover {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'hover' class is used here in conjunction with ':hover'. Ensure that this class is defined in your HTML and is intended for this specific styling. If it is meant to apply to all links, consider using a more general selector or applying the class consistently.

color: var(--blue-color) !important;
}

.img {
display: block;
padding: 10px 0;
width: 40px;
height: 40px;
}

.nav-bar {
display: flex;
align-items: center;
gap: 20px;
height: 60px;
}

.navigation {
display: flex;
justify-content: space-between;
gap: 419px;
background-color: #fff;
padding: 0 50px;

@media screen and (max-width: 1024px) {
gap: 243px;
}
}
Loading