Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5835

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #5835

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,12 @@
"keywords": [],
"author": "Mate Academy",
"license": "GPL-3.0",
"dependencies": {},
"devDependencies": {
"@linthtml/linthtml": "^0.9.6",
"@mate-academy/backstop-config": "latest",
"@mate-academy/bemlint": "latest",
"@mate-academy/linthtml-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^1.9.12",
"@mate-academy/stylelint-config": "latest",
"backstopjs": "6.3.23",
"jest": "^29.7.0",
Expand Down
4 changes: 2 additions & 2 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ The page should match the design Pixel Perfect: all the sizes, colors and distan

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/)
- [DEMO LINK](https://redkeyKA42.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://redkeyKA42.github.io/layout_moyo-header/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
63 changes: 62 additions & 1 deletion src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,74 @@
http-equiv="X-UA-Compatible"
content="ie=edge"
/>
<link
rel="preconnect"
href="https://fonts.googleapis.com"
/>
<link
rel="preconnect"
href="https://fonts.gstatic.com"
/>
<link
href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;500&display=swap"
rel="stylesheet"
/>
<title>Moyo header</title>
<link
rel="stylesheet"
href="./style.css"
/>
</head>
<body>
<h1>Moyo header</h1>
<!-- <h1>Moyo header</h1> -->
<header class="header">
<a
href="index.html"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to 'index.html'. If this link is intended to navigate to a different section or page, please ensure the href attribute is correctly set to the respective URL.

class="logo"
>
<img
src="images/logo.png"
redkeyKA42 marked this conversation as resolved.
Show resolved Hide resolved
alt="MOYOlogo"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider providing a more descriptive alt attribute for the logo image. Instead of 'MOYOlogo', using something like 'Moyo Company Logo' would improve accessibility.

/>
</a>
<nav class="nav">
<ul class="nav-links">
<li class="link">
<a
href="index.html"
redkeyKA42 marked this conversation as resolved.
Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to 'index.html'. If this link is intended to navigate to a different section or page, please ensure the href attribute is correctly set to the respective URL.

class="is-active"
>
apple
</a>
</li>
<li class="link">
<a href="index.html">samsung</a>
redkeyKA42 marked this conversation as resolved.
Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to 'index.html'. If this link is intended to navigate to a different section or page, please ensure the href attribute is correctly set to the respective URL.

</li>
<li class="link">
<a href="index.html">smartphones</a>
redkeyKA42 marked this conversation as resolved.
Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to 'index.html'. If this link is intended to navigate to a different section or page, please ensure the href attribute is correctly set to the respective URL.

</li>
<li class="link">
<a
href="index.html"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to 'index.html'. If this link is intended to navigate to a different section or page, please ensure the href attribute is correctly set to the respective URL.

data-qa="hover"
>
laptops & computers
</a>
</li>
<li class="link">
<a href="index.html">gadgets</a>
redkeyKA42 marked this conversation as resolved.
Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to 'index.html'. If this link is intended to navigate to a different section or page, please ensure the href attribute is correctly set to the respective URL.

</li>
<li class="link">
<a href="index.html">tablets</a>
redkeyKA42 marked this conversation as resolved.
Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to 'index.html'. If this link is intended to navigate to a different section or page, please ensure the href attribute is correctly set to the respective URL.

</li>
<li class="link">
<a href="index.html">photo</a>
redkeyKA42 marked this conversation as resolved.
Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to 'index.html'. If this link is intended to navigate to a different section or page, please ensure the href attribute is correctly set to the respective URL.

</li>
<li class="link last">
<a href="index.html">video</a>
redkeyKA42 marked this conversation as resolved.
Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to 'index.html'. If this link is intended to navigate to a different section or page, please ensure the href attribute is correctly set to the respective URL.

</li>
</ul>
</nav>
</header>
</body>
</html>
79 changes: 79 additions & 0 deletions src/style.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,82 @@
:root {
--primary-color: #00acdc;
}

html,
body {
redkeyKA42 marked this conversation as resolved.
Show resolved Hide resolved
width: 100%;
height: 100%;
margin: 0;
font-family: Roboto, sans-serif;
}

h1 {
margin: 38px 0;
redkeyKA42 marked this conversation as resolved.
Show resolved Hide resolved
}

.header {
justify-content: space-between;
display: flex;
align-items: center;
padding: 0 50px;
}

.logo {
display: flex;
align-items: center;
}

.nav {
height: 60px;
display: flex;
}

.nav-links {
display: flex;
height: 100%;
margin: 0;
padding: 0;
}

a {
text-decoration: none;
display: flex;
height: 100%;
align-items: center;
color: #000;
font-size: 12px;
font-weight: 500;
text-transform: uppercase;
}

a:hover {
color: var(--primary-color);
}

.is-active {
color: var(--primary-color);

position: relative;
}

.link {
text-decoration: none;
list-style: none;
margin-right: 20px;
}

.is-active::after {
width: 100%;
content: '';
position: absolute;
bottom: 0;
left: 0;
height: 4px;
background-color: var(--primary-color);

border-radius: 8px;
}

.last {
margin: 0;
}
Loading