-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5836
base: master
Are you sure you want to change the base?
add task solution #5836
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: Test | ||
|
||
on: | ||
pull_request: | ||
branches: [ master ] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
matrix: | ||
node-version: [20.x] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: npm install | ||
- run: npm test | ||
- name: Upload HTML report(backstop data) | ||
if: ${{ always() }} | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: report | ||
path: backstop_data |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"extends": [ | ||
"development" | ||
], | ||
"hints": { | ||
"meta-viewport": "off", | ||
"highest-available-document-mode": "off" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,22 @@ | |
/> | ||
</head> | ||
<body> | ||
<h1>Moyo header</h1> | ||
<header> | ||
<a href = "#" class="logo"> | ||
<img src="images/logo.png" alt="Moyo Logo"> | ||
</a> | ||
<nav> | ||
<ul> | ||
<li><a href="#" class ="is-active">Apple</a></li> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is an extra space around the |
||
<li><a href="#">Samsung</a></li> | ||
<li><a href="#">Smartphones</a></li> | ||
<li><a href="#" class ="hover">Laptops & Computers</a></li> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
<li><a href="#">Gadgets</a></li> | ||
<li><a href="#">Tablets</a></li> | ||
<li><a href="#">Photo</a></li> | ||
<li><a href="#">Video</a></li> | ||
</ul> | ||
</nav> | ||
</header> | ||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,83 @@ | ||
/* stylelint-disable font-family-name-quotes */ | ||
* { | ||
margin: 0; | ||
padding: 0; | ||
box-sizing: border-box; | ||
} | ||
|
||
body { | ||
font-family: 'Roboto', sans-serif; | ||
} | ||
|
||
/* header */ | ||
header { | ||
background-color: #fff; | ||
display: flex; | ||
align-items: center; | ||
padding: 0 20px; | ||
border-bottom: 1px solid #e0e0e0; | ||
} | ||
|
||
.logo { | ||
margin-right: 50px; | ||
} | ||
|
||
.logo img { | ||
max-height: 40px; | ||
} | ||
|
||
/* style */ | ||
nav ul { | ||
display: flex; | ||
list-style: none; | ||
margin: 0; | ||
padding: 0; | ||
} | ||
|
||
nav ul li:not(:first-child) { | ||
margin-left: 20px; | ||
} | ||
|
||
nav a { | ||
text-decoration: none; | ||
color: #333; | ||
display: inline-block; | ||
line-height: 60px; | ||
text-align: center; | ||
text-transform: uppercase; | ||
font-weight: 700; | ||
position: relative; | ||
} | ||
|
||
nav a.is-active { | ||
position: relative; | ||
color: #007bff; | ||
} | ||
|
||
nav a.is-active::after { | ||
content: ''; | ||
position: absolute; | ||
left: 0; | ||
bottom: -2px; | ||
width: 100%; | ||
height: 2px; | ||
background-color: #007bff; | ||
} | ||
|
||
nav a.hover { | ||
position: relative; | ||
color: #007bff; | ||
} | ||
Comment on lines
+67
to
+70
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Comment on lines
+67
to
+70
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
||
nav { | ||
flex-grow: 1; | ||
} | ||
|
||
/* stylelint-disable-next-line no-duplicate-selectors */ | ||
nav ul li:first-child { | ||
margin-left: 0; | ||
} | ||
|
||
nav ul li:last-child { | ||
margin-right: 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra space around the
=
in thehref
attribute. It should behref="#"
for consistency and to avoid potential issues.