Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5837

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TanyaMakarevich
Copy link

@TanyaMakarevich TanyaMakarevich commented Dec 18, 2024

  • DEMO LINK
  • TEST REPORT LINK
  • Header height is set in 1 place (for the links)
  • Content is vertically centered (for any header height)
  • CSS is used to show all letters in Uppercase (don't type them in HTML)
  • Logo is an image wrapped with a link
  • CSS Variable is used for a blue color
  • Pseudo-element is used for a blue line below the active link
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! 😊 You've done a great job with the structure and styling of your HTML and CSS files. However, there are a few critical issues that need to be addressed before we can approve your pull request:

  1. CSS Universal Selector: The use of the universal selector * to reset margins and paddings is against the checklist requirements due to potential performance impacts. Please replace this with a more specific approach.

  2. CSS Variable for Blue Color: The task requires using a CSS variable for the blue color, which is currently missing. Please define and use a CSS variable for this.

  3. Missing Files: Ensure that the src/images directory and the image files required for the logo are included in the project as specified in the task description.

Once these issues are resolved, your code will be in great shape! Keep up the good work, and feel free to reach out if you have any questions. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great effort on your project! 🎉 You've made significant progress by addressing some of the previous issues, such as removing the universal selector and implementing a CSS variable for the blue color. However, there are still a couple of critical points that need your attention:

  1. CSS Universal Selector: It's good to see that you've removed the universal selector *. Make sure to reset margins and paddings for necessary elements individually to meet the checklist requirements.

  2. Missing Image Files: The src/images directory and the image files for the logo are still not confirmed to be present. Please ensure these files are included in the project to display the logo correctly.

These adjustments are crucial for the functionality and performance of your project. While the decision is to APPROVE your Pull Request to help you move forward with your learning journey, please make sure to address these issues in future projects to avoid similar problems. Keep up the great work and continue improving your skills! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +31 to +32
<img
src="images/logo.png"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the src/images directory and the image files required for the logo are included in the project as specified in the task description. This is crucial for the logo to display correctly.

Comment on lines +5 to +14
body,
header,
nav,
h1,
h2,
h3,
p,
ul,
li,
a {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the universal selector to reset margins and paddings is against the checklist requirements due to potential performance impacts. Consider using a more specific approach to reset these properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants