Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop #5840

Closed
wants to merge 2 commits into from
Closed

develop #5840

wants to merge 2 commits into from

Conversation

KalianaBueno
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Hello! 😊 Thank you for your hard work on this project. There are a few critical issues that need to be addressed before we can approve this pull request:

  1. CSS Issues:

    • The task requires the use of a CSS variable for the blue color, which is currently missing.
    • The ::after pseudo-element should be used to create a blue line below the active link, as specified in the task.
    • The use of the * selector can impact performance and is advised against. Consider using more specific selectors.
  2. HTML Issues:

    • The HTML structure can be improved by nesting the <nav> and <ul> tags within the <header> tag for better semantic meaning.
    • The alt attribute for the image should be more descriptive to improve accessibility.
  3. General Issues:

    • Ensure that the header height is set in one place and that content is vertically centered for any header height.
    • All text should be displayed in uppercase using CSS.
  4. File Issues:

    • The src/images directory is mentioned but not included. Please ensure all necessary files are present.

Additionally, there's a minor typo in the navigation link text: 'Sansung' should be corrected to 'Samsung'.

Once these issues are resolved, your code will be much closer to meeting the task requirements. Keep up the great work, and don't hesitate to reach out if you need any help! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/index.html Outdated
<nav class="nav--bar">
<ul class="nav--links">
<li class="nav--link is-active"><a href="#">Apple</a></li>
<li class="nav--link"><a href="#">Sansung</a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the navigation link text 'Sansung'. It should be corrected to 'Samsung'.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants