Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starting-project #5860

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Dev-Lopes-Lucas
Copy link

@Dev-Lopes-Lucas Dev-Lopes-Lucas commented Dec 23, 2024

  • DEMO LINK

  • TEST REPORT LINK

  • Header height is set in 1 place (for the links)

  • Content is vertically centered (for any header height)

  • CSS is used to show all letters in Uppercase (don't type them in HTML)

  • Logo is an image wrapped with a link

  • CSS Variable is used for a blue color

  • Pseudo-element is used for a blue line below the active link

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a few critical issues that need to be addressed before we can approve your submission. The HTML file is missing essential semantic tags like <header>, <nav>, <ul>, <li>, and <a>, which are crucial for meeting the task requirements. Additionally, the content doesn't align with the task's design specifications, and there's no CSS file or evidence of using the Roboto font as required. Let's make these adjustments to ensure your solution meets the core requirements. Keep up the great work, and I'm confident you'll nail it with these changes! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

@Dev-Lopes-Lucas
Copy link
Author

Copy link

@pedro-ruas pedro-ruas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants