-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #5867
base: master
Are you sure you want to change the base?
Develop #5867
Changes from 5 commits
79700e2
6a74bf1
71e7c7f
d61a5c2
e11f432
c548e61
b4ebd03
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,8 +15,98 @@ | |
rel="stylesheet" | ||
href="./style.css" | ||
/> | ||
<link | ||
rel="preconnect" | ||
href="https://fonts.googleapis.com" | ||
/> | ||
<link | ||
rel="preconnect" | ||
href="https://fonts.gstatic.com" | ||
/> | ||
<link | ||
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&display=swap" | ||
rel="stylesheet" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You don't need all those weights imported. |
||
/> | ||
</head> | ||
<body> | ||
<header class="header"> | ||
<a href="#"> | ||
<img | ||
src="images/logo.png" | ||
alt="MOYO logo" | ||
class="header_top_logo" | ||
/> | ||
</a> | ||
<nav class="navigation"> | ||
<ul> | ||
<li> | ||
<a | ||
href="#apple" | ||
class="nav-link is-active" | ||
> | ||
apple | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
href="#samsung" | ||
class="nav-link" | ||
> | ||
samsung | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
href="#smartphones" | ||
class="nav-link" | ||
> | ||
smartphones | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
data-qa="hover" | ||
class="nav-link computers-link" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
href="#computers" | ||
> | ||
laptops & computers | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
href="#gadgets" | ||
class="nav-link" | ||
> | ||
gadgets | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
href="#tablets" | ||
class="nav-link" | ||
> | ||
tablets | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
href="#photo" | ||
class="nav-link" | ||
> | ||
photo | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
href="#video" | ||
class="nav-link" | ||
> | ||
video | ||
</a> | ||
</li> | ||
</ul> | ||
</nav> | ||
</header> | ||
<h1>Moyo header</h1> | ||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,80 @@ | ||
body { | ||
html { | ||
/* stylelint-disable-next-line font-family-name-quotes */ | ||
font-family: 'Roboto', sans-serif; | ||
font-size: 12px; | ||
font-style: normal; | ||
font-weight: 500; | ||
text-transform: uppercase; | ||
} | ||
|
||
* { | ||
margin: 0; | ||
} | ||
|
||
li { | ||
list-style: none; | ||
margin-left: 20px; | ||
} | ||
|
||
li:first-child { | ||
margin-left: 0; | ||
} | ||
|
||
ul { | ||
padding: 0; | ||
display: flex; | ||
} | ||
|
||
a { | ||
text-decoration: none; | ||
color: black; | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
.header { | ||
position: relative; | ||
width: 100%; | ||
margin: 0 auto; | ||
display: flex; | ||
align-items: center; | ||
justify-content: space-between; | ||
box-sizing: border-box; | ||
} | ||
|
||
.header_top_logo { | ||
margin-left: 50px; | ||
width: 40px; | ||
height: 40px; | ||
padding-top: 10px; | ||
padding-bottom: 10px; | ||
display: flex; | ||
} | ||
|
||
.is-active { | ||
position: relative; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The '.is-active' class is used to style active links. Ensure that this class is consistently applied in the HTML to avoid styling inconsistencies. |
||
color: #00acdc; | ||
} | ||
|
||
.is-active::after { | ||
content: ''; | ||
display: block; | ||
position: absolute; | ||
height: 4px; | ||
width: 100%; | ||
background-color: #00acdc; | ||
bottom: 0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are missing this requirement
|
||
border-radius: 8px; | ||
} | ||
|
||
.computers-link:hover { | ||
color: #00acdc; | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It should be |
||
.nav-link { | ||
line-height: 60px; | ||
height: 60px; | ||
display: inline-block; | ||
} | ||
|
||
.navigation { | ||
margin-right: 50px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in your file (not a tab character)