Add task solution! #5877
Open
Add task solution! #5877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
143HGS
commented
Dec 28, 2024
143HGS
commented
- DEMO LINK
- TEST REPORT LINK
- Header height is set in 1 place (for the links)
- Content is vertically centered (for any header height)
- CSS is used to show all letters in Uppercase (don't type them in HTML)
- Logo is an image wrapped with a link
- CSS Variable is used for a blue color
- Pseudo-element is used for a blue line below the active link
- Code follows all the Code Style Rules ❗️
mateacademy-ai-mentor
approved these changes
Dec 28, 2024
There was a problem hiding this comment.
Great job on your submission! 🎉 Your code meets most of the task requirements, and the functionality is intact. There are a couple of minor improvements you could make, such as using a CSS variable for the blue color and revisiting the logo positioning for better responsiveness. These changes will enhance your code's maintainability and adaptability. Keep up the excellent work, and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
etojeDenys
suggested changes
Dec 28, 2024
Comment on lines
+19
to
+45
|
|
||
| header { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| background-color: #fff; | ||
| flex-direction: row; | ||
| max-height: 60px; | ||
| } | ||
|
|
||
| .logo img { | ||
| position: absolute; | ||
| left: 50px; | ||
| top: 10px; | ||
| } | ||
|
|
||
| nav { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| margin-right: 50px; | ||
| } | ||
|
|
||
| a { | ||
| text-transform: uppercase; | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.