Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5879

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #5879

wants to merge 2 commits into from

Conversation

krismva
Copy link

@krismva krismva commented Dec 28, 2024

  • DEMO LINK

  • TEST REPORT LINK

  • [ x] Header height is set in 1 place (for the links)

  • [ x] Content is vertically centered (for any header height)

  • [ x] CSS is used to show all letters in Uppercase (don't type them in HTML)

  • [ x] Logo is an image wrapped with a link

  • [ x] CSS Variable is used for a blue color

  • [ x] Pseudo-element is used for a blue line below the active link

  • [ x] Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on your submission! 🎉 Your code meets the core requirements and functionality of the task. There are a few minor improvements you could consider:

  1. Flex Gap Usage: Replace the gap property with margin in the .nav__list class as specified in the task requirements.
  2. Line Length: Break down lines in the HTML file to adhere to the 80-character limit for better readability.
  3. Performance Optimization: Consider adding the crossorigin attribute to the preconnect link for 'fonts.gstatic.com' for improved performance.

These are minor adjustments and don't affect the overall functionality. Keep up the great work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/index.html Outdated
Comment on lines 17 to 20
<link
rel="preconnect"
href="https://fonts.gstatic.com"
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding the 'crossorigin' attribute to the preconnect link for 'fonts.gstatic.com' to improve performance. This is a recommended practice when using preconnect for external resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants