-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #5880
base: master
Are you sure you want to change the base?
Develop #5880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! 😊 You've done a great job with your code, and it's clear you've put a lot of effort into it. However, there are a couple of critical issues that need to be addressed before we can approve the pull request:
-
Font-Weight Property: The
font-weight
property is incorrectly set to500px
. It should be a numeric value like500
without thepx
unit. This is important for the text to render correctly. -
Href Attribute Encoding: The
href
attribute in one of your navigation links contains an ampersand (&
). It should be encoded as&
to ensure proper HTML rendering and functionality.
Once these issues are resolved, your code will be in great shape! Keep up the good work, and I look forward to seeing the updated version. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on addressing the previous issues! 🎉 Your code now meets the task requirements and constraints as specified. Here are some key points from the review:
-
Font-Weight Property: You've correctly set the
font-weight
to500
without thepx
unit, ensuring consistency across your styles. -
Href Attribute Encoding: The
href
attribute in the navigation links no longer contains an unencoded ampersand (&
). However, ensure that any future URLs use&
for proper HTML rendering.
While the code is approved, it's important to keep in mind the critical issue regarding the href
attribute. Make sure to encode special characters in URLs to comply with HTML standards. This will help you avoid similar issues in the future and improve your coding skills. Keep up the good work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
</li> | ||
<li class="nav__items"> | ||
<a | ||
href="#laptopsandcomputers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href
attribute contains an ampersand (&
) which should be encoded as &
to ensure proper HTML rendering and functionality. Update the href
to #laptops&computers
.
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️