Develop #5881
Develop #5881
Conversation
MarushchakM
commented
Dec 28, 2024
•
MarushchakM
commented
- DEMO LINK
- TEST REPORT LINK
- Header height is set in 1 place (for the links)
- Content is vertically centered (for any header height)
- CSS is used to show all letters in Uppercase (don't type them in HTML)
- Logo is an image wrapped with a link
- CSS Variable is used for a blue color
- Pseudo-element is used for a blue line below the active link
- Code follows all the [Code Style Rules ❗️]
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 The code is well-structured and meets most of the criteria. While there are a few minor suggestions, such as providing a more similar fallback font to 'Roboto', ensuring the font path is correct, and considering meaningful URLs for navigation links, these do not impact the core functionality. Keep up the good work and consider these improvements for future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <a | ||
| href="#" |
There was a problem hiding this comment.
The href attribute for the logo link is set to #, which means it doesn't lead anywhere. Consider providing a meaningful URL or using javascript:void(0); if the link is not intended to navigate.
| <a | ||
| class="is-active" | ||
| href="#" |
There was a problem hiding this comment.
The href attribute for the navigation links is set to #, which means they don't lead anywhere. Consider providing meaningful URLs for these links to improve navigation.
| <a | ||
| href="#" | ||
| data-qa="hover" |
There was a problem hiding this comment.
The data-qa attribute is used here, which is typically for testing purposes. Ensure this is intentional and necessary for your project.
| @@ -1,3 +1,76 @@ | |||
| @font-face { | |||
| font-family: Roboto; | |||
| src: url(fonts/Roboto-Medium.ttf); | |||
There was a problem hiding this comment.
Ensure that the path to the font file is correct and that the font file is available in the specified location. Otherwise, the font may not load properly.
| body { | ||
| margin: 0; | ||
| font-family: Roboto, serif; |
There was a problem hiding this comment.
Consider providing a fallback font that is more similar to 'Roboto' than 'serif', such as 'Arial' or 'Helvetica', for better consistency across different browsers and systems.
