Develop #5117
Develop #5117
Conversation
There was a problem hiding this comment.
Great job on your implementation! 🎉 The structure and styling are well-executed, and the minor issue with SCSS variable usage doesn't impact the overall functionality. Keep up the good work, and consider refining the variable usage for even cleaner code in the future. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| font-weight: 500; | ||
| font-size: 12px; | ||
| line-height: 18px; | ||
| color: variables.$main-accent; |
There was a problem hiding this comment.
There is an issue with the SCSS variable usage here. The correct syntax for using a variable in SCSS is variables.$variable-name. Ensure that the variables.scss file contains the $main-accent variable and that it is imported correctly.
| font-weight: 400; | ||
| font-size: 10px; | ||
| line-height: 14px; | ||
| color: variables.$secondary-accent; |
There was a problem hiding this comment.
There is an issue with the SCSS variable usage here. The correct syntax for using a variable in SCSS is variables.$variable-name. Ensure that the variables.scss file contains the $secondary-accent variable and that it is imported correctly.
| font-size: 10px; | ||
| line-height: 14px; | ||
| text-align: right; | ||
| color: variables.$main-accent; |
There was a problem hiding this comment.
There is an issue with the SCSS variable usage here. The correct syntax for using a variable in SCSS is variables.$variable-name. Ensure that the variables.scss file contains the $main-accent variable and that it is imported correctly.
| font-weight: 400; | ||
| font-size: 12px; | ||
| line-height: 18px; | ||
| color: variables.$secondary-accent; |
There was a problem hiding this comment.
There is an issue with the SCSS variable usage here. The correct syntax for using a variable in SCSS is variables.$variable-name. Ensure that the variables.scss file contains the $secondary-accent variable and that it is imported correctly.
| font-size: 16px; | ||
| line-height: 18px; | ||
| text-align: right; | ||
| color: variables.$main-accent; |
There was a problem hiding this comment.
There is an issue with the SCSS variable usage here. The correct syntax for using a variable in SCSS is variables.$variable-name. Ensure that the variables.scss file contains the $main-accent variable and that it is imported correctly.
| border: none; | ||
| border-radius: 5px; | ||
| text-decoration: none; | ||
| background-color: variables.$blue-accent; |
There was a problem hiding this comment.
There is an issue with the SCSS variable usage here. The correct syntax for using a variable in SCSS is variables.$variable-name. Ensure that the variables.scss file contains the $blue-accent variable and that it is imported correctly.
|
|
||
| &:hover { | ||
| background-color: white; | ||
| color: variables.$blue-accent; |
There was a problem hiding this comment.
There is an issue with the SCSS variable usage here. The correct syntax for using a variable in SCSS is variables.$blue-accent. Ensure that the variables.scss file contains the $blue-accent variable and that it is imported correctly.
| &:hover { | ||
| background-color: white; | ||
| color: variables.$blue-accent; | ||
| border: 1px solid variables.$blue-accent; |
There was a problem hiding this comment.
There is an issue with the SCSS variable usage here. The correct syntax for using a variable in SCSS is variables.$blue-accent. Ensure that the variables.scss file contains the $blue-accent variable and that it is imported correctly.
DEMO LINK
TEST REPORT LINK
there 2 BEM blocks
cardandstarseach in their own fileSCSS Nesting is used for
elements,modifiersandpseudo-classesSCSS Variables are used for main values and placed in a separate file
all
stars--Nmodifiers work as expected (Highlight firstNstars)Code follows all the Code Style Rules ❗️