-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #5126
base: master
Are you sure you want to change the base?
Develop #5126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work! 😊 While your code is well-structured and mostly meets the task requirements, there are a few critical issues that need addressing before we can approve the PR. Specifically, the BEM blocks card
and stars
need to be in separate files, SCSS variables should be in their own file, and the image paths for the stars need correction. Please make these changes to fully meet the task requirements. Keep up the great work, and I'm confident you'll nail it! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your submission! 🎉 Your code meets most of the task requirements and constraints, and you've successfully addressed many of the previous issues. Here are a few points to consider for further improvement:
-
SCSS Compilation: Ensure that the
index.scss
file is compiled into a CSS file by your build tool (Parcel) before being linked in the HTML. This is crucial for the styles to be applied correctly. -
SCSS Variables: It's important that all SCSS variables, such as
$btn-color-first
,$btn-color-second
,$light-color
, and$base-color
, are defined in a separatevariables.scss
file and imported correctly. This helps maintain consistency and avoid errors related to undefined variables. -
Image Paths: Double-check that the images
star-active.svg
andstar.svg
exist in the../images/
directory and that the paths are correct. This ensures that the star ratings display as intended.
Your effort and attention to detail are commendable. Keep up the good work, and make sure to address these points in future projects to enhance your coding skills. Remember, learning from these experiences will help you grow as a developer. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
display: flex; | ||
flex-direction: column; | ||
font-size: 10px; | ||
color: $base-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $base-color
is used here. Ensure that it is defined in a separate SCSS variables file and imported correctly.
font-weight: 500; | ||
font-size: 12px; | ||
line-height: 18px; | ||
color: $base-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $base-color
is used here again. Ensure that it is defined in a separate SCSS variables file and imported correctly.
|
||
&__code { | ||
line-height: 14px; | ||
color: $light-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $light-color
is used here. Ensure that it is defined in a separate SCSS variables file and imported correctly.
|
||
&__price-lable { | ||
font-size: 12px; | ||
color: $light-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $light-color
is used here again. Ensure that it is defined in a separate SCSS variables file and imported correctly.
} | ||
&__btn { | ||
display: block; | ||
color: $btn-color-second; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $btn-color-second
is used here. Ensure that it is defined in a separate SCSS variables file and imported correctly.
font-size: 14px; | ||
text-align: center; | ||
&:hover { | ||
background-color: $btn-color-second; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $btn-color-second
is used here again. Ensure that it is defined in a separate SCSS variables file and imported correctly.
text-align: center; | ||
&:hover { | ||
background-color: $btn-color-second; | ||
color: $btn-color-first; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $btn-color-first
is used here again. Ensure that it is defined in a separate SCSS variables file and imported correctly.
.stars { | ||
display: flex; | ||
&__star { | ||
background-image: url(../images/star.svg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the image star.svg
exists in the ../images/
directory and the path is correct.
.stars--3 .stars__star:nth-child(-n + 3), | ||
.stars--4 .stars__star:nth-child(-n + 4), | ||
.stars--5 .stars__star:nth-child(-n + 5) { | ||
background-image: url(../images/star-active.svg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the image star-active.svg
exists in the ../images/
directory and the path is correct.
@@ -1,3 +1,15 @@ | |||
@import 'https://fonts.googleapis.com/css2?family=Roboto:wght@400;500;700&display=swap'; | |||
@import './utils/variables'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the variables
file is correctly set up and contains all the necessary SCSS variables used across the project. This is crucial for maintaining consistency and avoiding errors related to undefined variables.
-[x] there 2 BEM blocks card and stars each in their own file
-[x] SCSS Nesting is used for elements, modifiers and pseudo-classes
-[x] SCSS Variables are used for main values and placed in a separate file
-[x] all stars--N modifiers work as expected (Highlight first N stars)
-[x] Code follows all the Code Style Rules ❗️