Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #5133

wants to merge 2 commits into from

Conversation

KristinaMelnyk
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your submission is on the right track, but there are a few critical areas that need attention to meet the task requirements. 🚀

  1. BEM Blocks: Ensure that the card and stars blocks are separated into individual files as required by the task.
  2. SCSS Variables: Introduce SCSS variables for main values and place them in a separate file to enhance maintainability and readability.
  3. Stars Block: Reimplement the stars block using SCSS in a separate file, as this is a core requirement.
  4. SCSS Nesting: Double-check that all elements, modifiers, and pseudo-classes are properly nested to fully utilize SCSS capabilities.
  5. File Structure: Address the missing files for the stars block and SCSS variables, and remove any unnecessary files like index.css if SCSS is being compiled directly.

These changes are essential to align with the task's core requirements. Keep up the great work, and I'm confident you'll nail it with these adjustments! 🌟

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants