Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout_product_cards #5177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nadiaaamf
Copy link

[x] there 2 BEM blocks card and stars each in their own file
[x] SCSS Nesting is used for elements, modifiers and pseudo-classes
[x] SCSS Variables are used for main values and placed in a separate file
[x] all stars--N modifiers work as expected (Highlight first N stars)
[x] Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 Your code meets the core requirements of the task, including the correct use of BEM blocks, SCSS nesting, and variables. The implementation of the stars modifiers using a loop is particularly clever. While there are minor issues like ensuring image paths are correctly set relative to index.scss and removing unrelated files, these do not impact the functionality of your code. Keep up the excellent work, and consider these small improvements for future projects! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants