-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5287
base: master
Are you sure you want to change the base?
add task solution #5287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are a few critical issues that need to be addressed before we can approve your submission. 🚧
-
BEM Blocks Separation: The task requires the
card
andstars
BEM blocks to be in separate files, but currently, both are inindex.scss
. Please separate them into individual files as specified. -
SCSS Variables: The task specifies using SCSS variables for main values in a separate file, which is missing. This is important for maintainability and should be addressed.
-
Missing Files: There is no separate SCSS file for the
stars
block, which is required. Additionally, the SCSS variables file is missing.
These changes are necessary to meet the core requirements of the task. Once you've made these updates, feel free to resubmit! Keep up the good work, and don't hesitate to reach out if you need any help. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
<link | ||
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100..900;1,100..900&display=swap" | ||
rel="stylesheet" | ||
/> | ||
<link | ||
rel="stylesheet" | ||
href="./styles/index.scss" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href
attribute is linking to an SCSS file (index.scss
). Ensure that your build process (e.g., Parcel) is correctly configured to handle SCSS files and compile them into CSS. If not, this link might not apply the styles as expected in the browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress! 🎉 You've successfully separated the BEM blocks into individual SCSS files, which is a crucial step. However, there are still some areas for improvement. It's important to create a separate SCSS variables file to enhance maintainability and consistency across your styles. This will help you manage repeated values like dimensions, colors, and font properties more effectively. Addressing these issues will not only improve your current project but also your future work. Keep up the good work and continue learning from these experiences!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<link | ||
href="https://fonts.googleapis.com/css2?family=Roboto:wdth,[email protected],100..900&display=swap" | ||
rel="stylesheet" | ||
/> | ||
<link | ||
rel="stylesheet" | ||
href="./styles/index.scss" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The task requires separating BEM blocks into individual SCSS files. Currently, the index.scss
file is linked here, which suggests that both card
and stars
blocks might be in the same file. Please ensure that these blocks are separated into their respective SCSS files as per the task requirements.
width: 200px; | ||
|
||
padding: 0 16px; | ||
border-radius: 5px; | ||
border: 1px solid #f3f3f3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using SCSS variables for main values like width, padding, border-radius, and border color. This will make your styles more maintainable and consistent.
background-color: #00acdc; | ||
border-radius: 5px; | ||
border: 1px solid transparent; | ||
padding: 12px 0; | ||
margin: 16px 0; | ||
|
||
color: #fff; | ||
font-weight: 700; | ||
font-size: 14px; | ||
line-height: 16px; | ||
text-transform: uppercase; | ||
} | ||
|
||
.button:hover { | ||
border-radius: 5px; | ||
border: 1px solid #00acdc; | ||
background-color: #fff; | ||
color: #00acdc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using SCSS variables for colors and other repeated values can help maintain consistency and make future changes easier.
height: 16px; | ||
width: 16px; | ||
margin: 0 2px; | ||
background-repeat: no-repeat; | ||
background-position: center; | ||
background-image: url(../images/star.svg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using SCSS variables for repeated values such as height, width, and image paths. This will make your styles more maintainable and consistent.
font-family: Roboto, sans-serif; | ||
font-size: 12px; | ||
font-weight: 500; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using SCSS variables for font properties like font-family
, font-size
, and font-weight
. This will help maintain consistency and make it easier to update these values across your styles.
DEMO LINK
TEST REPORT LINK
there 2 BEM blocks
card
andstars
each in their own fileSCSS Nesting is used for
elements
,modifiers
andpseudo-classes
SCSS Variables are used for main values and placed in a separate file
all
stars--N
modifiers work as expected (Highlight firstN
stars)Code follows all the Code Style Rules ❗️