Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First commit - search bar #3768

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

First commit - search bar #3768

wants to merge 8 commits into from

Conversation

baraban2003
Copy link

@baraban2003 baraban2003 commented Nov 11, 2023 •
edited
Loading

  • DEMO LINK

  • TEST REPORT LINK

  • Icon implemented using background-image CSS property

  • Inputs are written inside of 'form' tag with correctly passed attributes

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 12, 2023
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you need to add your demo and test links to the PR description

src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
SanyaBratashchuk
SanyaBratashchuk suggested changes Nov 12, 2023
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compare your result with design once more and try to fix tests

src/index.html Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Show resolved Hide resolved
@baraban2003
Copy link
Author

baraban2003 commented Nov 12, 2023 •
edited
Loading

//compare your result with the design once more and try to fix tests
Hi, this is impossible. The code looks good and everything is as in design. I move pixels back and forth and I think it's silly work. But I don't know what tests want from me. It's crazy and it looks like jeer (

VitaliyBodnar
VitaliyBodnar suggested changes Nov 12, 2023
View reviewed changes
Copy link

@VitaliyBodnar VitaliyBodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ask you question in the fe_chat

src/style.css Outdated Show resolved Hide resolved
src/style.css Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
Esceype
Esceype approved these changes Nov 12, 2023
View reviewed changes
Copy link

@Esceype Esceype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ🚀🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Esceype Esceype Esceype approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@SanyaBratashchuk SanyaBratashchuk Awaiting requested review from SanyaBratashchuk

@VitaliyBodnar VitaliyBodnar Awaiting requested review from VitaliyBodnar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baraban2003 @Esceype @VitaliyBodnar @volodymyr-soltys97 @SanyaBratashchuk