add two search bar #3782
Open
add two search bar #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiia-tilikina
suggested changes
Nov 16, 2023
src/style.css
Outdated
Comment on lines
26
to
27
| margin-left: 26px; | ||
| margin-top: 25px; |
There was a problem hiding this comment.
since you're using flex you can center elements more easily) use flex properties (e.g. align-items)
src/style.css
Outdated
| } | ||
|
|
||
| .search__form:focus-within, | ||
| .search__form:focus-within .search__input { |
There was a problem hiding this comment.
use input:focus instead of form:focus
src/style.css
Outdated
| .search__form { | ||
| box-sizing: border-box; | ||
| display: flex; | ||
| height: 70px; |
There was a problem hiding this comment.
it is bad practice to hardcode height. use proper padding instead
loralevitska
suggested changes
Nov 19, 2023
src/index.html
Outdated
Comment on lines
20
to
23
| <img | ||
| src="./images/Search.svg" | ||
| alt="search" | ||
| class="icon"> |
There was a problem hiding this comment.
Suggested change
| <img | |
| src="./images/Search.svg" | |
| alt="search" | |
| class="icon"> | |
| <img | |
| src="./images/Search.svg" | |
| alt="search" | |
| class="icon" | |
| > |
|
Tests passed without errors, when I used height. But my code was rejected and mentor told me that it is better to use paddings. When i use padding, I have error in code. Chat with mentors could not help) |
anastasiiavorobiova
suggested changes
Nov 19, 2023
loralevitska
approved these changes
Nov 19, 2023
src/style.css
Outdated
| } | ||
|
|
||
| .search__input:focus::placeholder { | ||
| font-style: normal; |
There was a problem hiding this comment.
Remove redundant default value
Suggested change
| font-style: normal; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
Icon implemented using background-image CSS property
Inputs are written inside of 'form' tag with correctly passed attributes
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️