Layout search airbnb #4695
Layout search airbnb #4695
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 While your code meets most of the requirements, there are a few critical issues that need to be addressed before we can approve the pull request. The missing data-qa attribute in the second form's input element is important for consistency and testing purposes, which is a core requirement of the task. Please add data-qa="keypress" to ensure both forms are consistent. Once this is resolved, your solution will be ready for approval. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| <input | ||
| class="search-bar__input search-bar__input--small" | ||
| type="text" | ||
| placeholder="Try “Los Angeles“" | ||
| /> |
There was a problem hiding this comment.
The input element in the second form is missing the data-qa attribute. Consider adding data-qa="keypress" to maintain consistency with the first form and potentially for testing purposes.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
Something went wrong while processing the review.
[CODE: 2]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Great job on addressing the previously mentioned issue by adding the data-qa="keypress" attribute to the input element in the big search form! 🎉 Your code now meets the task requirements and constraints as specified. The HTML and CSS files are well-structured and adhere to the specified guidelines, including the use of @font-face for fonts and the correct implementation of search bars.
While the code is approved, remember to always ensure consistency in your attributes to avoid critical issues in the future. This will help maintain the functionality and reliability of your code. Keep up the good work and continue learning from each task! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| > | ||
| <input | ||
| type="text" | ||
| data-qa="hover" |
There was a problem hiding this comment.
The data-qa attribute should be data-qa="keypress" to match the requirement for consistency across both input elements. Please update this attribute.
-[x] Ícone implementado usando propriedade CSS background-image
-[x] As entradas são escritas dentro da tag 'form' com atributos passados corretamente
-[x] Todas Typical Mistakesas BEMaulas teóricas são verificadas.
-[x] O código segue todas as regras de estilo de código ❗️