Create solution #4734
Create solution #4734
Conversation
There was a problem hiding this comment.
Great job on your submission! 🎉 Your code meets the task requirements, and the functionality is intact. There are a couple of minor improvements you might consider: ensure the data-qa attribute is consistent across form inputs if needed for your logic, and double-check the commented-out CSS line to see if it should be active. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <input | ||
| class="search-input search-input--small" | ||
| type="text" | ||
| placeholder="Try "Los Angeles"" | ||
| /> |
There was a problem hiding this comment.
The second form input is missing the data-qa attribute that is present in the first form input. Consider adding data-qa="keypress" to maintain consistency if it is required for your application logic.
|
|
||
| /* background: linear-gradient(var(--gradient_white-top-color),var(--gradient_white-bottom-color)); */ |
There was a problem hiding this comment.
The line defining a background gradient is commented out. If this is intentional, you can ignore this comment. Otherwise, consider uncommenting it to apply the gradient effect when the input is focused.
DEMO LINK
TEST REPORT LINK
Icon implemented using background-image CSS property
Inputs are written inside of 'form' tag with correctly passed attributes
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️